chrome/renderer/printing/print_web_view_helper_win.cc - Issue 255543006: Printing on Windows via PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_win.cc

Issue 255543006: Printing on Windows via PDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: almost working; SafePlayback failing in final print Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/print_web_view_helper_win.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_win.cc b/chrome/renderer/printing/print_web_view_helper_win.cc

index 4e80461979614df6a42ef9ed0de7ea8952641021..14980e36f64075ad07bbfc8121461f51898a1a76 100644

--- a/chrome/renderer/printing/print_web_view_helper_win.cc

+++ b/chrome/renderer/printing/print_web_view_helper_win.cc

@@ -4,6 +4,9 @@

#include "chrome/renderer/printing/print_web_view_helper.h"

+// XXX TODO in .gyp instead

+#if !defined(PRINTING_WIN_USES_PDF_AS_METAFILE)

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram.h"

@@ -247,3 +250,5 @@ bool PrintWebViewHelper::CopyMetafileDataToSharedMem(

}

} // namespace printing

+#endif // !PRINTING_WIN_USES_PDF_AS_METAFILE