chrome/renderer/printing/print_web_view_helper.cc - Issue 255543006: Printing on Windows via PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 255543006: Printing on Windows via PDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: almost working; SafePlayback failing in final print Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/print_web_view_helper.cc

diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc

index 259601ebea87b0e37cfa143e94b45b9ecfa87fd2..392d40afe3b89cb73801634788224e76986ef53d 100644

--- a/chrome/renderer/printing/print_web_view_helper.cc

+++ b/chrome/renderer/printing/print_web_view_helper.cc

@@ -1351,7 +1351,7 @@ void PrintWebViewHelper::FinishFramePrinting() {

prep_frame_view_.reset();

}

-#if defined(OS_MACOSX) || defined(OS_WIN)

+#if defined(OS_MACOSX) || !defined(PRINTING_WIN_USES_PDF_AS_METAFILE)

bool PrintWebViewHelper::PrintPagesNative(blink::WebFrame* frame,

int page_count,

const gfx::Size& canvas_size) {

@@ -1376,7 +1376,7 @@ bool PrintWebViewHelper::PrintPagesNative(blink::WebFrame* frame,

return true;

}

-#endif // OS_MACOSX || OS_WIN

+#endif // OS_MACOSX || !PRINTING_WIN_USES_PDF_AS_METAFILE

// static - Not anonymous so that platform implementations can use it.

void PrintWebViewHelper::ComputePageLayoutInPointsForCss(