Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: printing/metafile_impl.h

Issue 255543006: Printing on Windows via PDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tidy Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/utility/chrome_content_utility_client.cc ('K') | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/metafile_impl.h
diff --git a/printing/metafile_impl.h b/printing/metafile_impl.h
index 840a1cede68ccad26eac75303d9ffedf1fcd7b17..317c9de26a780351cc72e400beb42653a4d1c10c 100644
--- a/printing/metafile_impl.h
+++ b/printing/metafile_impl.h
@@ -7,16 +7,22 @@
#include "printing/pdf_metafile_skia.h"
+#if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
+// TODO(scottmg): http://crbug.com/170859. The #if here should really be "has
+// PDF DLL" not GOOGLE_CHROME_BUILD specifically, or perhaps a gyp setting?
Vitaly Buka (NO REVIEWS) 2014/05/13 23:54:33 GYP is better
scottmg 2014/05/14 00:34:48 Done. win_pdf_metafile_for_printing=1 in GYP_DEFIN
+#define PRINTING_WIN_USES_PDF_AS_METAFILE
+#endif
+
#if defined(OS_WIN)
#include "printing/emf_win.h"
#endif
namespace printing {
-#if defined(OS_WIN)
+#if !defined(PRINTING_WIN_USES_PDF_AS_METAFILE)
typedef Emf NativeMetafile;
typedef PdfMetafileSkia PreviewMetafile;
-#elif defined(OS_POSIX)
+#else
typedef PdfMetafileSkia NativeMetafile;
typedef PdfMetafileSkia PreviewMetafile;
#endif
« chrome/utility/chrome_content_utility_client.cc ('K') | « content/renderer/pepper/pepper_plugin_instance_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698