Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255543003: CodeStubs contain their corresponding Isolate* now. (part 2) (Closed)

Created:
6 years, 8 months ago by Sven Panne
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

CodeStubs contain their corresponding Isolate* now. (part 2) This CL mechanically removes all useless Isolate* parameters from code stub functions, making things quite a bit simpler. BUG=359977 LOG=y R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20940

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -583 lines) Patch
M src/arm/code-stubs-arm.cc View 34 chunks +27 lines, -58 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +5 lines, -5 lines 2 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 34 chunks +26 lines, -57 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 46 chunks +83 lines, -118 lines 0 comments Download
M src/code-stubs.cc View 13 chunks +34 lines, -35 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 31 chunks +63 lines, -66 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/frames.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 31 chunks +22 lines, -52 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic.cc View 11 chunks +15 lines, -16 lines 0 comments Download
M src/stub-cache.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 31 chunks +21 lines, -52 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
6 years, 8 months ago (2014-04-24 10:59:36 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/255543003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/255543003/diff/1/src/arm/macro-assembler-arm.cc#newcode113 src/arm/macro-assembler-arm.cc:113: stub->GetCode(), RelocInfo::CODE_TARGET, ast_id, cond); nit: Should fit into ...
6 years, 8 months ago (2014-04-24 11:48:13 UTC) #2
Sven Panne
Feedback addressed, landing... https://codereview.chromium.org/255543003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/255543003/diff/1/src/arm/macro-assembler-arm.cc#newcode113 src/arm/macro-assembler-arm.cc:113: stub->GetCode(), RelocInfo::CODE_TARGET, ast_id, cond); On 2014/04/24 ...
6 years, 8 months ago (2014-04-24 12:02:20 UTC) #3
Sven Panne
6 years, 8 months ago (2014-04-24 12:08:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r20940 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698