Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2555423002: Move white-space to be generated in ComputedStyleBase. (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move white-space to be generated in ComputedStyleBase. Move white-space to be generated in ComputedStyleBase. Also removed the explicit value setters for EWhiteSpace. Also updated SameSizeAsComputedStyle() to reflect the change in inherited data bitfield size. This CL has reduced the size of ComputedStyle by 8 bytes. BUG=628043 Committed: https://crrev.com/b6cb04f1dbef1277a5a51b3ae3f5e6cb0341a614 Cr-Commit-Position: refs/heads/master@{#437322}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated SameSizeAsComputedStyle() to reflect the change in inherited data bitfield size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 6 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 4 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
napper
https://codereview.chromium.org/2555423002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in File third_party/WebKit/Source/core/css/CSSProperties.in (right): https://codereview.chromium.org/2555423002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in#newcode444 third_party/WebKit/Source/core/css/CSSProperties.in:444: white-space inherited, independent, keyword_only, keywords=[normal|pre|pre-wrap|pre-line|nowrap|-webkit-nowrap], initial_keyword=normal Please confirm that ...
4 years ago (2016-12-08 01:46:44 UTC) #6
esprehn
You should mention what the size change was here. Did you make it bigger or ...
4 years ago (2016-12-08 01:55:02 UTC) #7
napper
On 2016/12/08 at 01:55:02, esprehn wrote: > You should mention what the size change was ...
4 years ago (2016-12-08 02:04:51 UTC) #9
sashab
Can confirm -webkit-nowrap is correct - this is the value is CSSKeywordValues.in Woohoo we reduced ...
4 years ago (2016-12-08 02:11:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555423002/20001
4 years ago (2016-12-08 02:52:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81863)
4 years ago (2016-12-08 04:22:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555423002/20001
4 years ago (2016-12-08 19:52:49 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 20:36:13 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-08 20:39:33 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6cb04f1dbef1277a5a51b3ae3f5e6cb0341a614
Cr-Commit-Position: refs/heads/master@{#437322}

Powered by Google App Engine
This is Rietveld 408576698