Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2555393003:
win: Switch to 10.0.14393.0 SDK (Closed)
Descriptionwin: Switch to 10.0.14393.0 SDK
The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0
SDK, during the switch to VS 2015 Update 3. The only reason the SDK
wasn't switched at the same time was to isolate the two changes from
each other, and there's no reason I am aware not to change the SDK now.
R=brucedawson@chromium.org
BUG=440500
Committed: https://crrev.com/b77dd4921b8c3bd94d4543d88dfc160a85dbf868
Cr-Commit-Position: refs/heads/master@{#437190}
Patch Set 1 #Patch Set 2 : Add landmines entry to force (?) a build through analyze #
Messages
Total messages: 24 (15 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
If it passes the try bots then lgtm The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. Feel free to add the paragraph above to the CL description if you want.
Description was changed from ========== win: Switch to 10.0.14393.0 SDK R=brucedawson@chromium.org BUG=440500 ========== to ========== win: Switch to 10.0.14393.0 SDK The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. R=brucedawson@chromium.org BUG=440500 ==========
On 2016/12/08 01:11:33, brucedawson wrote: > If it passes the try bots then lgtm > > The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, > during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched > at the same time was to isolate the two changes from each other, and there's no > reason I am aware not to change the SDK now. > > Feel free to add the paragraph above to the CL description if you want. Done, thanks.
Description was changed from ========== win: Switch to 10.0.14393.0 SDK The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. R=brucedawson@chromium.org BUG=440500 ========== to ========== win: Switch to 10.0.14393.0 SDK The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. R=brucedawson@chromium.org BUG=440500 ==========
Speaking of analyze being smart, but not quite smart enough... :/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brucedawson@chromium.org Link to the patchset: https://codereview.chromium.org/2555393003/#ps20001 (title: "Add landmines entry to force (?) a build through analyze")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481171791988560,
"parent_rev": "e28bdda77338663a99a70cea024bb16f7ec5fb68", "commit_rev":
"800b861c8622cba83af1e764b014c22675750738"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== win: Switch to 10.0.14393.0 SDK The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. R=brucedawson@chromium.org BUG=440500 ========== to ========== win: Switch to 10.0.14393.0 SDK The 10.0.14393.0 SDK was packaged at the same time as the 10.0.10586.0 SDK, during the switch to VS 2015 Update 3. The only reason the SDK wasn't switched at the same time was to isolate the two changes from each other, and there's no reason I am aware not to change the SDK now. R=brucedawson@chromium.org BUG=440500 Committed: https://crrev.com/b77dd4921b8c3bd94d4543d88dfc160a85dbf868 Cr-Commit-Position: refs/heads/master@{#437190} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b77dd4921b8c3bd94d4543d88dfc160a85dbf868 Cr-Commit-Position: refs/heads/master@{#437190}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
same comment as ever time: can we come up with a way to do this without a landmine please?
Message was sent while issue was closed.
On 2017/01/09 16:23:04, Nico wrote: > same comment as ever time: can we come up with a way to do this without a > landmine please? Strongly agreed. scottmg@ filed crbug.com/672319 to request and track this. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
