Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: ash/common/system/tray/tray_background_view.cc

Issue 2555373004: Apply new MD shadows to CrOS tray bubbles. (Closed)
Patch Set: leave activation alone Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/bubble/bubble_border.cc » ('j') | ui/views/bubble/bubble_border.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/tray_background_view.cc
diff --git a/ash/common/system/tray/tray_background_view.cc b/ash/common/system/tray/tray_background_view.cc
index 0b4f6bc96e661ad17a63dea2744b13678e74eb54..8e96e95947098df1196d97f710942e88fe40c2f5 100644
--- a/ash/common/system/tray/tray_background_view.cc
+++ b/ash/common/system/tray/tray_background_view.cc
@@ -533,20 +533,12 @@ views::View* TrayBackgroundView::GetBubbleAnchor() const {
gfx::Insets TrayBackgroundView::GetBubbleAnchorInsets() const {
gfx::Insets anchor_insets = GetBubbleAnchor()->GetInsets();
gfx::Insets tray_bg_insets = GetInsets();
- // TODO(estade): for reasons I don't understand, BubbleBorder distances the
- // bubble by the arrow's "interior" thickness even when the paint type is
- // PAINT_NONE.
- const int kBigShadowArrowInteriorThickness = 9;
if (GetAnchorAlignment() == TrayBubbleView::ANCHOR_ALIGNMENT_BOTTOM) {
- return gfx::Insets(kBigShadowArrowInteriorThickness - tray_bg_insets.top(),
- anchor_insets.left(), -tray_bg_insets.bottom(),
- anchor_insets.right());
+ return gfx::Insets(-tray_bg_insets.top(), anchor_insets.left(),
+ -tray_bg_insets.bottom(), anchor_insets.right());
} else {
- return gfx::Insets(
- anchor_insets.top(),
- kBigShadowArrowInteriorThickness - tray_bg_insets.left(),
- anchor_insets.bottom(),
- kBigShadowArrowInteriorThickness - tray_bg_insets.right());
+ return gfx::Insets(anchor_insets.top(), -tray_bg_insets.left(),
+ anchor_insets.bottom(), -tray_bg_insets.right());
}
}
« no previous file with comments | « no previous file | ui/views/bubble/bubble_border.cc » ('j') | ui/views/bubble/bubble_border.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698