Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: ui/views/bubble/tray_bubble_view.cc

Issue 2555373004: Apply new MD shadows to CrOS tray bubbles. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/tray_bubble_view.cc
diff --git a/ui/views/bubble/tray_bubble_view.cc b/ui/views/bubble/tray_bubble_view.cc
index 53a050606e6e86622582a524c42eacbb9c09bbf1..11cae58f74e7a009a8c04ebf43e756111b232350 100644
--- a/ui/views/bubble/tray_bubble_view.cc
+++ b/ui/views/bubble/tray_bubble_view.cc
@@ -173,7 +173,6 @@ TrayBubbleView::InitParams::InitParams(AnchorAlignment anchor_alignment,
min_width(min_width),
max_width(max_width),
max_height(0),
- can_activate(false),
close_on_deactivate(true),
bg_color(gfx::kPlaceholderColor) {}
@@ -196,14 +195,14 @@ TrayBubbleView::TrayBubbleView(View* anchor,
delegate_(delegate),
preferred_width_(init_params.min_width),
bubble_border_(new BubbleBorder(arrow(),
- BubbleBorder::BIG_SHADOW,
+ BubbleBorder::NO_ASSETS,
init_params.bg_color)),
owned_bubble_border_(bubble_border_),
is_gesture_dragging_(false),
mouse_actively_entered_(false) {
bubble_border_->set_alignment(BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
bubble_border_->set_paint_arrow(BubbleBorder::PAINT_NONE);
- set_can_activate(params_.can_activate);
+ set_can_activate(true);
msw 2016/12/08 22:09:46 nit: this is true by default; remove the explicit
DCHECK(anchor_widget()); // Computed by BubbleDialogDelegateView().
set_notify_enter_exit_on_child(true);
set_close_on_deactivate(init_params.close_on_deactivate);
@@ -272,6 +271,7 @@ void TrayBubbleView::OnBeforeBubbleWidgetInit(Widget::InitParams* params,
Widget* bubble_widget) const {
if (delegate_)
delegate_->OnBeforeBubbleWidgetInit(anchor_widget(), bubble_widget, params);
+ params->shadow_type = Widget::InitParams::SHADOW_TYPE_DROP;
}
NonClientFrameView* TrayBubbleView::CreateNonClientFrameView(Widget* widget) {

Powered by Google App Engine
This is Rietveld 408576698