Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2555373003: MD Settings: Deactivate the Camera when leaving the Change Picture page. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Deactivate the Camera when leaving the Change Picture page. BUG=669853 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e898cc4841ff1de534c30c33f9c76b9df7b3f796 Cr-Commit-Position: refs/heads/master@{#437392}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : fix closure compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.js View 1 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources2.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/people_page_change_picture_test.js View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
tommycli
dbeam: PTAL, thanks!
4 years ago (2016-12-08 02:46:27 UTC) #3
Dan Beam
what about if the user closes the page directly? (i.e. doesn't navigate away)
4 years ago (2016-12-08 03:35:26 UTC) #4
tommycli
On 2016/12/08 03:35:26, Dan Beam wrote: > what about if the user closes the page ...
4 years ago (2016-12-08 17:36:55 UTC) #5
Dan Beam
lgtm test?
4 years ago (2016-12-08 19:00:57 UTC) #6
tommycli
dbeam: Thanks. I added a test!
4 years ago (2016-12-08 19:35:20 UTC) #8
Dan Beam
bitchin' lgtm++
4 years ago (2016-12-08 19:36:10 UTC) #11
tommycli
On 2016/12/08 19:36:10, Dan Beam wrote: > bitchin' > > lgtm++ thanks. cq++
4 years ago (2016-12-08 19:38:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555373003/40001
4 years ago (2016-12-08 19:38:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82594)
4 years ago (2016-12-08 20:27:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555373003/60001
4 years ago (2016-12-08 21:18:21 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-08 23:04:19 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-08 23:06:21 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e898cc4841ff1de534c30c33f9c76b9df7b3f796
Cr-Commit-Position: refs/heads/master@{#437392}

Powered by Google App Engine
This is Rietveld 408576698