MD Settings: Deactivate the Camera when leaving the Change Picture page.

MD Settings: Deactivate the Camera when leaving the Change Picture page.

BUG=669853
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e898cc4841ff1de534c30c33f9c76b9df7b3f796
Cr-Commit-Position: refs/heads/master@{#437392}

[tommycli, 2016-12-08 02:45:52]

Description was changed from

==========
MD Settings: Deactivate the Camera when leaving the Change Picture page.

BUG=669853
==========

to

==========
MD Settings: Deactivate the Camera when leaving the Change Picture page.

BUG=669853
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-12-08 02:46:27]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-12-08 02:46:27]

dbeam: PTAL, thanks!

[Dan Beam, 2016-12-08 03:35:26]

what about if the user closes the page directly?  (i.e. doesn't navigate away)

[tommycli, 2016-12-08 17:36:55]

On 2016/12/08 03:35:26, Dan Beam wrote:
> what about if the user closes the page directly?  (i.e. doesn't navigate away)

Hey Dan, 

There is no problem there. Closing the tab or window also kills the camera
stream.

Tommy

[Dan Beam, 2016-12-08 19:00:57]

lgtm

test?

[tommycli, 2016-12-08 19:34:58]

Patchset #2 (id:20001) has been deleted

[tommycli, 2016-12-08 19:35:20]

dbeam: Thanks. I added a test!

[tommycli, 2016-12-08 19:35:24]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:36:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-08 19:36:10]

bitchin'

lgtm++

[tommycli, 2016-12-08 19:38:18]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-12-08 19:38:18]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-12-08 19:38:25]

On 2016/12/08 19:36:10, Dan Beam wrote:
> bitchin'
> 
> lgtm++

thanks. cq++

[commit-bot: I haz the power, 2016-12-08 19:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:27:49]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tommycli, 2016-12-08 21:17:36]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-12-08 21:17:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2555373003/#ps60001
(title: "fix closure compile")

[commit-bot: I haz the power, 2016-12-08 21:18:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:03:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481231856792530,
"parent_rev": "8c8102a266ac5b104b38be50be656b7a981c4e68", "commit_rev":
"262d8052bd2c3a30f3de16709d6f23f1943cd4b0"}

[commit-bot: I haz the power, 2016-12-08 23:04:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-08 23:06:19]

Description was changed from

==========
MD Settings: Deactivate the Camera when leaving the Change Picture page.

BUG=669853
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Deactivate the Camera when leaving the Change Picture page.

BUG=669853
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e898cc4841ff1de534c30c33f9c76b9df7b3f796
Cr-Commit-Position: refs/heads/master@{#437392}
==========

[commit-bot: I haz the power, 2016-12-08 23:06:21]

Patchset 3 (id:??) landed as
https://crrev.com/e898cc4841ff1de534c30c33f9c76b9df7b3f796
Cr-Commit-Position: refs/heads/master@{#437392}