Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2555373002: Use unique_ptr for CXFA_XMLParser. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use unique_ptr for CXFA_XMLParser. Also rename CFDE_XMLParser to IFDE_XMLParser since its an interface. Committed: https://pdfium.googlesource.com/pdfium/+/64f4e25304dfd93651ac5c9d5379ed2fffbb993f

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Alphabetize class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 2 chunks +9 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 3 chunks +11 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/cxfa_xml_parser.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_xml_parser.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-08 00:27:25 UTC) #4
dsinclair
lgtm
4 years ago (2016-12-08 02:52:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555373002/40001
4 years ago (2016-12-08 02:52:21 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-08 03:01:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/64f4e25304dfd93651ac5c9d5379ed2fffbb...

Powered by Google App Engine
This is Rietveld 408576698