Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 255533002: cc: Remove unused_memory_limit_in_bytes field from GlobalStateThatImpactsTilePriority. (Closed)

Created:
6 years, 8 months ago by reveman
Modified:
6 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Remove unused_memory_limit_in_bytes field from GlobalStateThatImpactsTilePriority. This field is not used by the tile manager as it only affects the resource pool and the tile manager is no longer responsible for forwarding these changes to the resource pool. Also removes inappropriate call to SetResourceUsageLimits in TileManager::SetGlobalStateForTesting. R=vmpstr BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M cc/resources/tile_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/tile_manager_perftest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M cc/resources/tile_priority.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/tile_priority.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
reveman
6 years, 8 months ago (2014-04-24 02:56:02 UTC) #1
vmpstr
lgtm
6 years, 8 months ago (2014-04-25 19:07:14 UTC) #2
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-25 19:34:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/255533002/1
6 years, 8 months ago (2014-04-25 22:10:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:45:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:45:40 UTC) #6
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-25 23:46:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/255533002/1
6 years, 8 months ago (2014-04-25 23:50:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 03:56:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 03:56:23 UTC) #10
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-26 03:58:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/255533002/1
6 years, 8 months ago (2014-04-26 03:59:57 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 04:41:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 04:41:59 UTC) #14
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 8 months ago (2014-04-26 15:33:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/255533002/1
6 years, 8 months ago (2014-04-26 15:34:56 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 07:08:45 UTC) #17
Message was sent while issue was closed.
Change committed as 266462

Powered by Google App Engine
This is Rietveld 408576698