[wasm][asm.js] Confirm literals are Numbers before using AsNumber, refactor.

[wasm][asm.js] Confirm literals are Numbers before using AsNumber, refactor.

We have been assuming in several places that ContainsDot or ToInt32 is
sufficient to check a value is a valid double or int.
Refactoring all the checks to one place and making them cope with booleans
or other unexpected types being present.

BUG=672044
R=titzer@chromium.org

Committed: https://crrev.com/4a637abea3eb1a07b0059d047bc1c647ce331859
Cr-Commit-Position: refs/heads/master@{#41595}

[bradnelson, 2016-12-08 10:40:27]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 10:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-12-08 10:45:53]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[commit-bot: I haz the power, 2016-12-08 10:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 10:55:04]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[bradnelson, 2016-12-08 13:31:38]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:31:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-12-08 13:32:04]

ptal

[commit-bot: I haz the power, 2016-12-08 13:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 13:57:22]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-08 14:11:32]

lgtm

https://codereview.chromium.org/2555323003/diff/20001/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2555323003/diff/20001/src/asmjs/asm-typer.cc#...
src/asmjs/asm-typer.cc:469: bool IsLiteral1_0(Literal* literal) {
IsLiteral1Dot0?

[bradn, 2016-12-08 14:21:59]

https://codereview.chromium.org/2555323003/diff/20001/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2555323003/diff/20001/src/asmjs/asm-typer.cc#...
src/asmjs/asm-typer.cc:469: bool IsLiteral1_0(Literal* literal) {
On 2016/12/08 14:11:32, titzer wrote:
> IsLiteral1Dot0?

Done.

[bradn, 2016-12-08 14:22:24]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-12-08 14:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2555323003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-12-08 14:22:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:54:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481206944274950,
"parent_rev": "367a0aca65932ca1d2b86073e8b377a365989110", "commit_rev":
"0c5e49d8f5016b3595e914d4be98bbe5d2a6eb84"}

[commit-bot: I haz the power, 2016-12-08 14:54:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 14:55:11]

Description was changed from

==========
[wasm][asm.js] Confirm literals are Numbers before using AsNumber, refactor.

We have been assuming in several places that ContainsDot or ToInt32 is
sufficient to check a value is a valid double or int.
Refactoring all the checks to one place and making them cope with booleans
or other unexpected types being present.

BUG=672044
R=titzer@chromium.org
==========

to

==========
[wasm][asm.js] Confirm literals are Numbers before using AsNumber, refactor.

We have been assuming in several places that ContainsDot or ToInt32 is
sufficient to check a value is a valid double or int.
Refactoring all the checks to one place and making them cope with booleans
or other unexpected types being present.

BUG=672044
R=titzer@chromium.org

Committed: https://crrev.com/4a637abea3eb1a07b0059d047bc1c647ce331859
Cr-Commit-Position: refs/heads/master@{#41595}
==========

[commit-bot: I haz the power, 2016-12-08 14:55:12]

Patchset 3 (id:??) landed as
https://crrev.com/4a637abea3eb1a07b0059d047bc1c647ce331859
Cr-Commit-Position: refs/heads/master@{#41595}