Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2555303005: Set ImeListView's scrollable range when updating (Closed)

Created:
4 years ago by Azure Wei
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Set ImeListView's scrollable range when updating For material design, we need to set turns the scroll view (listing all current IMEs) into a bounded scroll view, with a fixed height. When switching IME, this needs to set again and then call Layout() & SchedulePaint(). Since the range should not change during switching IMEs, we pass the range in the constructor of ImeListView instead of ImeListView::Update() every time. TBR=tdanderson@chromium.org NOPRESUBMIT=true NOTRY=true BUG=667650 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2541743004 Cr-Commit-Position: refs/heads/master@{#437168} (cherry picked from commit 29b403dc3d47bb52477c4bf5324b46557d38cd38)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 4 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555303005/1
4 years ago (2016-12-09 00:47:36 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-09 01:08:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698