Move ADJoinErrorType from authpolicy to authpolicy::types namespace

Move ADJoinErrorType from authpolicy to authpolicy::types namespace

authpolicy::ADJoinErrorType conflicts with type defined in cros system
api dbus service constants, and prevents cros_service_api DEPS uprev.

BUG=659732
Committed: https://crrev.com/5e74d62ee9a204f4ce47432219a754897bd80830
Cr-Commit-Position: refs/heads/master@{#437102}

[tbarzic, 2016-12-07 21:52:01]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 21:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2016-12-07 21:52:44]

tbarzic@chromium.org changed reviewers:
+ rsorokin@chromium.org, stevenjb@chromium.org

[tbarzic, 2016-12-07 21:52:45]

conflicting enum was added here:
https://chromium-review.googlesource.com/#/c/403809/

[stevenjb, 2016-12-07 22:02:13]

This seems fine, as long as we are planning to eliminate the enum once the uprev
occurs.

(Alternately, we could just make the enum a member of AuthPolicyClient).

[stevenjb, 2016-12-07 22:02:19]

lgtm

[tbarzic, 2016-12-07 22:08:06]

On 2016/12/07 22:02:19, stevenjb wrote:
> lgtm

yes, I plan to eliminate the enum after I update DEPS.

[commit-bot: I haz the power, 2016-12-07 22:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:09:48]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Roman Sorokin (ftl), 2016-12-07 22:13:52]

lgtm

[tbarzic, 2016-12-07 22:20:02]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 22:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:59:02]

Dry run: This issue passed the CQ dry run.

[tbarzic, 2016-12-07 22:59:36]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2016-12-07 22:59:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, rsorokin@chromium.org
Link to the patchset: https://codereview.chromium.org/2555293002/#ps20001
(title: "missed one")

[commit-bot: I haz the power, 2016-12-07 23:00:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:08:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481151576453980,
"parent_rev": "de3720de66b93397afd0e183bf7a70977adfd6ad", "commit_rev":
"3dd938031a43477655965a475cae83c3f2b8ff98"}

[commit-bot: I haz the power, 2016-12-07 23:09:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 23:11:47]

Description was changed from

==========
Move ADJoinErrorType from authpolicy to authpolicy::types namespace

authpolicy::ADJoinErrorType conflicts with type defined in cros system
api dbus service constants, and prevents cros_service_api DEPS uprev.

BUG=659732
==========

to

==========
Move ADJoinErrorType from authpolicy to authpolicy::types namespace

authpolicy::ADJoinErrorType conflicts with type defined in cros system
api dbus service constants, and prevents cros_service_api DEPS uprev.

BUG=659732

Committed: https://crrev.com/5e74d62ee9a204f4ce47432219a754897bd80830
Cr-Commit-Position: refs/heads/master@{#437102}
==========

[commit-bot: I haz the power, 2016-12-07 23:11:48]

Patchset 2 (id:??) landed as
https://crrev.com/5e74d62ee9a204f4ce47432219a754897bd80830
Cr-Commit-Position: refs/heads/master@{#437102}