Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2555263002: [Interpreter] Add expression positions to BinaryOps. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy, Clemens Hammacher
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add expression positions to BinaryOps. BUG=v8:5723 Committed: https://crrev.com/bfc53f6ed0a7159f7bbf63c6a2b1e35f57b5b7d7 Cr-Commit-Position: refs/heads/master@{#41583}

Patch Set 1 #

Patch Set 2 : Add message test #

Total comments: 2

Patch Set 3 : Move test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -132 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden View 7 chunks +21 lines, -21 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 31 chunks +86 lines, -70 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveExpressions.golden View 11 chunks +23 lines, -17 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Switch.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden View 6 chunks +11 lines, -10 lines 0 comments Download
A test/message/tonumber-symbol.js View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A test/message/tonumber-symbol.out View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
rmcilroy
This means we can no longer perform the LdaSmi+Add -> AddSmi peephole optimization as often ...
4 years ago (2016-12-07 19:09:05 UTC) #6
Michael Starzinger
LGTM. Thanks! https://codereview.chromium.org/2555263002/diff/20001/test/message/tonumber_symbol.js File test/message/tonumber_symbol.js (right): https://codereview.chromium.org/2555263002/diff/20001/test/message/tonumber_symbol.js#newcode1 test/message/tonumber_symbol.js:1: // Copyright 2016 the V8 project authors. ...
4 years ago (2016-12-08 09:13:21 UTC) #9
rmcilroy
https://codereview.chromium.org/2555263002/diff/20001/test/message/tonumber_symbol.js File test/message/tonumber_symbol.js (right): https://codereview.chromium.org/2555263002/diff/20001/test/message/tonumber_symbol.js#newcode1 test/message/tonumber_symbol.js:1: // Copyright 2016 the V8 project authors. All rights ...
4 years ago (2016-12-08 09:46:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555263002/40001
4 years ago (2016-12-08 09:46:31 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 10:11:10 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-08 10:11:26 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bfc53f6ed0a7159f7bbf63c6a2b1e35f57b5b7d7
Cr-Commit-Position: refs/heads/master@{#41583}

Powered by Google App Engine
This is Rietveld 408576698