src/wasm/wasm-module-builder.h - Issue 2555243002: [wasm] Fix location for error in asm.js ToNumber conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module-builder.h

Issue 2555243002: [wasm] Fix location for error in asm.js ToNumber conversion (Closed)

Patch Set: Fix gc error by storing callee_pc_address Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module-builder.h

diff --git a/src/wasm/wasm-module-builder.h b/src/wasm/wasm-module-builder.h

index 4f32abe7bd81f8c1758db614f85c28e02c1caca3..ae1bfee65d4dbf7aaddda1fb8d2e25740e1cfe8a 100644

--- a/src/wasm/wasm-module-builder.h

+++ b/src/wasm/wasm-module-builder.h

@@ -134,7 +134,7 @@ class V8_EXPORT_PRIVATE WasmFunctionBuilder : public ZoneObject {

void EmitDirectCallIndex(uint32_t index);

void ExportAs(Vector<const char> name);

void SetName(Vector<const char> name);

- void AddAsmWasmOffset(int asm_position);

+ void AddAsmWasmOffset(int call_position, int to_number_position);

void WriteSignature(ZoneBuffer& buffer) const;

void WriteExports(ZoneBuffer& buffer) const;

« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/wasm/wasm-module-builder.cc » ('j') | no next file with comments »