Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: src/frames.h

Issue 2555243002: [wasm] Fix location for error in asm.js ToNumber conversion (Closed)
Patch Set: Fix gc error by storing callee_pc_address Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 0b1adfb95c681e489d85a3612bd338f419b08fea..06703dd52cfc2a95788c82b4839d8aa138c7f23e 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -441,12 +441,11 @@ class StackFrame BASE_EMBEDDED {
};
struct State {
- State() : sp(NULL), fp(NULL), pc_address(NULL),
- constant_pool_address(NULL) { }
- Address sp;
- Address fp;
- Address* pc_address;
- Address* constant_pool_address;
+ Address sp = nullptr;
+ Address fp = nullptr;
+ Address* pc_address = nullptr;
+ Address* callee_pc_address = nullptr;
+ Address* constant_pool_address = nullptr;
};
// Copy constructor; it breaks the connection to host iterator
@@ -485,6 +484,7 @@ class StackFrame BASE_EMBEDDED {
// Accessors.
Address sp() const { return state_.sp; }
Address fp() const { return state_.fp; }
+ Address callee_pc() const { return *state_.callee_pc_address; }
Address caller_sp() const { return GetCallerStackPointer(); }
// If this frame is optimized and was dynamically aligned return its old
@@ -1111,6 +1111,7 @@ class WasmFrame : public StandardFrame {
uint32_t function_index() const;
Script* script() const override;
int position() const override;
+ bool at_to_number_conversion() const;
static WasmFrame* cast(StackFrame* frame) {
DCHECK(frame->is_wasm());
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698