Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: src/frames.h

Issue 2555243002: [wasm] Fix location for error in asm.js ToNumber conversion (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 0b1adfb95c681e489d85a3612bd338f419b08fea..a443cb71d2cfeb3f8f935b30b9c72daa53f175e0 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -562,6 +562,8 @@ class StackFrame BASE_EMBEDDED {
void operator=(const StackFrame& original) = delete;
protected:
+ const StackFrameIteratorBase* iterator_;
Michael Starzinger 2016/12/08 11:38:05 nit: AFAICT this is only made protected due to a D
Clemens Hammacher 2016/12/08 12:15:37 Sure, I just dropped the DCHECK.
+
inline explicit StackFrame(StackFrameIteratorBase* iterator);
virtual ~StackFrame() { }
@@ -581,7 +583,6 @@ class StackFrame BASE_EMBEDDED {
#endif
private:
- const StackFrameIteratorBase* iterator_;
Isolate* isolate_;
State state_;
@@ -1111,6 +1112,7 @@ class WasmFrame : public StandardFrame {
uint32_t function_index() const;
Script* script() const override;
int position() const override;
+ bool at_to_number_conversion() const;
static WasmFrame* cast(StackFrame* frame) {
DCHECK(frame->is_wasm());
@@ -1134,6 +1136,8 @@ class WasmToJsFrame : public StubFrame {
inline explicit WasmToJsFrame(StackFrameIteratorBase* iterator);
private:
+ void ComputeCallerState(State* state) const override;
+
friend class StackFrameIteratorBase;
};
« src/compiler/pipeline.cc ('K') | « src/compiler/wasm-compiler.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698