Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/wasm/wasm-objects.h

Issue 2555243002: [wasm] Fix location for error in asm.js ToNumber conversion (Closed)
Patch Set: Fix gc error by storing callee_pc_address Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/wasm/wasm-module-builder.cc ('k') | src/wasm/wasm-objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_WASM_OBJECTS_H_ 5 #ifndef V8_WASM_OBJECTS_H_
6 #define V8_WASM_OBJECTS_H_ 6 #define V8_WASM_OBJECTS_H_
7 7
8 #include "src/debug/interface-types.h" 8 #include "src/debug/interface-types.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 #include "src/trap-handler/trap-handler.h" 10 #include "src/trap-handler/trap-handler.h"
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 int GetContainingFunction(uint32_t byte_offset) const; 289 int GetContainingFunction(uint32_t byte_offset) const;
290 290
291 // Translate from byte offset in the module to function number and byte offset 291 // Translate from byte offset in the module to function number and byte offset
292 // within that function, encoded as line and column in the position info. 292 // within that function, encoded as line and column in the position info.
293 // Returns true if the position is valid inside this module, false otherwise. 293 // Returns true if the position is valid inside this module, false otherwise.
294 bool GetPositionInfo(uint32_t position, Script::PositionInfo* info); 294 bool GetPositionInfo(uint32_t position, Script::PositionInfo* info);
295 295
296 // Get the asm.js source position from a byte offset. 296 // Get the asm.js source position from a byte offset.
297 // Must only be called if the associated wasm object was created from asm.js. 297 // Must only be called if the associated wasm object was created from asm.js.
298 static int GetAsmJsSourcePosition(Handle<WasmCompiledModule> debug_info, 298 static int GetAsmJsSourcePosition(Handle<WasmCompiledModule> debug_info,
299 uint32_t func_index, uint32_t byte_offset); 299 uint32_t func_index, uint32_t byte_offset,
300 bool is_at_number_conversion);
300 301
301 // Compute the disassembly of a wasm function. 302 // Compute the disassembly of a wasm function.
302 // Returns the disassembly string and a list of <byte_offset, line, column> 303 // Returns the disassembly string and a list of <byte_offset, line, column>
303 // entries, mapping wasm byte offsets to line and column in the disassembly. 304 // entries, mapping wasm byte offsets to line and column in the disassembly.
304 // The list is guaranteed to be ordered by the byte_offset. 305 // The list is guaranteed to be ordered by the byte_offset.
305 // Returns an empty string and empty vector if the function index is invalid. 306 // Returns an empty string and empty vector if the function index is invalid.
306 debug::WasmDisassembly DisassembleFunction(int func_index); 307 debug::WasmDisassembly DisassembleFunction(int func_index);
307 308
308 private: 309 private:
309 void InitId(); 310 void InitId();
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 }; 380 };
380 }; 381 };
381 382
382 #undef DECLARE_ACCESSORS 383 #undef DECLARE_ACCESSORS
383 #undef DECLARE_OPTIONAL_ACCESSORS 384 #undef DECLARE_OPTIONAL_ACCESSORS
384 385
385 } // namespace internal 386 } // namespace internal
386 } // namespace v8 387 } // namespace v8
387 388
388 #endif // V8_WASM_OBJECTS_H_ 389 #endif // V8_WASM_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/wasm/wasm-module-builder.cc ('k') | src/wasm/wasm-objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698