[iOS] Upstreaming of Info.plist and entitlements generation.

[iOS] Upstreaming of Info.plist and entitlements generation.

Add ios/build/chrome_build.gni file containing variable controlling
the build and information that used during generation of Info.plist
for chrome application.

Upstream the targets to generate the application Info.plist and the
entitlements file, plus their templates, and some addition for the
EarlGrey tests.

BUG=None

Committed: https://crrev.com/92cd50727fc12fbdb5061bfbd3c667fddd66069b
Cr-Commit-Position: refs/heads/master@{#437214}

[sdefresne, 2016-12-07 17:26:29]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 17:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 17:29:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sdefresne, 2016-12-07 17:29:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 17:30:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 17:33:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2016-12-07 18:08:28]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-12-07 18:08:38]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2016-12-07 18:08:44]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-07 18:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-07 18:08:58]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-07 18:08:59]

Please take a look and send to CQ if LGTY.

[commit-bot: I haz the power, 2016-12-07 19:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 19:27:24]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-12-07 21:56:04]

lgtm

https://codereview.chromium.org/2555233002/diff/40001/ios/build/chrome_build.gni
File ios/build/chrome_build.gni (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/build/chrome_build....
ios/build/chrome_build.gni:40: chromium_bundle_id = "chrome.ios.herebedragons"
This results in a bundleid of org.chromium.chrome.ios.herebedragons.  It would
be better if we could drop the "chrome" component.

Not something that necessarily needs to be addressed in this CL, but we should
audit all of the various bundleids that we're generating.

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
File ios/chrome/app/resources/BUILD.gn (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
ios/chrome/app/resources/BUILD.gn:83: bundle_data("quick_action_icons") {
"resources_quick_actions" would be a more standardized naming of this target. 
Matches "resources" and "resources_unit_tests".

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
File ios/chrome/app/resources/EncryptionExportCompliance+Info.plist (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
ios/chrome/app/resources/EncryptionExportCompliance+Info.plist:8:
<string>${ENCRYPTION_EXPORT_COMPLIANCE_CODE}</string>
How does a value get from the GN variable into this file?

[sdefresne, 2016-12-08 08:51:31]

https://codereview.chromium.org/2555233002/diff/40001/ios/build/chrome_build.gni
File ios/build/chrome_build.gni (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/build/chrome_build....
ios/build/chrome_build.gni:40: chromium_bundle_id = "chrome.ios.herebedragons"
On 2016/12/07 21:56:04, rohitrao wrote:
> This results in a bundleid of org.chromium.chrome.ios.herebedragons.  It would
> be better if we could drop the "chrome" component.
> 
> Not something that necessarily needs to be addressed in this CL, but we should
> audit all of the various bundleids that we're generating.

I don't really know how we can drop "chrome" from this bundle id now (as it is
embedded in the mobile provisioning profiles, in the App Store and in the key
used for code signing the official build).

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
File ios/chrome/app/resources/BUILD.gn (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
ios/chrome/app/resources/BUILD.gn:83: bundle_data("quick_action_icons") {
On 2016/12/07 21:56:04, rohitrao wrote:
> "resources_quick_actions" would be a more standardized naming of this target. 
> Matches "resources" and "resources_unit_tests".

quick_action_*.png are only referenced from the Info.plist as are
chromium/Icon-*.png. So I named the target adding icons only referenced from the
Info.plist using the same convention.

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
File ios/chrome/app/resources/EncryptionExportCompliance+Info.plist (right):

https://codereview.chromium.org/2555233002/diff/40001/ios/chrome/app/resource...
ios/chrome/app/resources/EncryptionExportCompliance+Info.plist:8:
<string>${ENCRYPTION_EXPORT_COMPLIANCE_CODE}</string>
On 2016/12/07 21:56:04, rohitrao wrote:
> How does a value get from the GN variable into this file?

The key=value substitution happens when the final Info.plist is generated which
happens as part of the ios_app_bundle target (via the extra_substitutions).
Currently the code is downstream only but will be upstreamed when the
corresponding target is moved upstream.

[sdefresne, 2016-12-08 08:51:36]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-08 08:51:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:55:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481187096590970,
"parent_rev": "41b37798801ed2d574b9a736b52cb6a072135fb5", "commit_rev":
"f195b163edf3683aecf9041c0005c0da1993626c"}

[commit-bot: I haz the power, 2016-12-08 08:56:23]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-12-08 09:01:14]

Description was changed from

==========
[iOS] Upstreaming of Info.plist and entitlements generation.

Add ios/build/chrome_build.gni file containing variable controlling
the build and information that used during generation of Info.plist
for chrome application.

Upstream the targets to generate the application Info.plist and the
entitlements file, plus their templates, and some addition for the
EarlGrey tests.

BUG=None
==========

to

==========
[iOS] Upstreaming of Info.plist and entitlements generation.

Add ios/build/chrome_build.gni file containing variable controlling
the build and information that used during generation of Info.plist
for chrome application.

Upstream the targets to generate the application Info.plist and the
entitlements file, plus their templates, and some addition for the
EarlGrey tests.

BUG=None

Committed: https://crrev.com/92cd50727fc12fbdb5061bfbd3c667fddd66069b
Cr-Commit-Position: refs/heads/master@{#437214}
==========

[commit-bot: I haz the power, 2016-12-08 09:01:18]

Patchset 1 (id:??) landed as
https://crrev.com/92cd50727fc12fbdb5061bfbd3c667fddd66069b
Cr-Commit-Position: refs/heads/master@{#437214}