CHANGELOG.md - Issue 2555223004: Fix behavior causing frames lacking a source map to always be omitted. Add `includeUnmappedFrames` …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: CHANGELOG.md

Issue 2555223004: Fix behavior causing frames lacking a source map to always be omitted. Add `includeUnmappedFrames` … (Closed)

Patch Set: Fix behavior so frames that do not match the source map are still be emitted if the new `includeUnm… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 ## 1.1.3+1
	nweiz 2016/12/08 23:34:31 Build numbers ("+x") are only used for packages wi Build numbers ("+x") are only used for packages with a major version of 0. This should be 1.1.4. Jacob 2016/12/09 02:18:28 Done. Show quoted text On 2016/12/08 23:34:31, nweiz wrote: > Build numbers ("+x") are only used for packages with a major version of 0. This > should be 1.1.4. Done.
	2

	3 * Fix behavior so frames that do not match the source map can still be emitted

	4 by adding `includeUnmappedFrames` named parameter enabling showing unmapped

	5 frames in a backwards compatible manner.
	nweiz 2016/12/08 23:34:31 This is a bit of a run-on sentence. Maybe: "Add a This is a bit of a run-on sentence. Maybe: "Add an `includeUnmappedFrames` parameter to `mapStackTrace`. If `true`, frames that aren't covered by the source map are included in the resulting trace." Jacob 2016/12/09 02:18:28 Done. Show quoted text On 2016/12/08 23:34:31, nweiz wrote: > This is a bit of a run-on sentence. Maybe: > > "Add an `includeUnmappedFrames` parameter to `mapStackTrace`. If `true`, frames > that aren't covered by the source map are included in the resulting trace." Done.
	6

	7 * Pass stack frame uris to source map `Mapping` fixing bug where source

	8 map lookups occurred using the wrong file.
	nweiz 2016/12/08 23:34:31 Changelog entries should just describe the user-vi Changelog entries should just describe the user-visible behavior, not the underlying implementation. Under what circumstances would a user have seen the bug in previous versions? Why was the behavior wrong? What does it do now? Jacob 2016/12/09 02:18:28 just removed. not worth mentioning. Show quoted text On 2016/12/08 23:34:31, nweiz wrote: > Changelog entries should just describe the user-visible behavior, not the > underlying implementation. Under what circumstances would a user have seen the > bug in previous versions? Why was the behavior wrong? What does it do now? just removed. not worth mentioning.
	9

1 ## 1.1.3	10 ## 1.1.3

2	11

3 * Add a missing dependency on `path`.	12 * Add a missing dependency on `path`.

4	13

5 ## 1.1.2	14 ## 1.1.2

6	15

7 * Fix a typo in the previous fix.	16 * Fix a typo in the previous fix.

8	17

9 ## 1.1.1	18 ## 1.1.1

10	19

(...skipping 26 matching lines...) Expand all Loading...
37	46

38 * Fix an off-by-one bug that was causing line numbers to be slightly off.	47 * Fix an off-by-one bug that was causing line numbers to be slightly off.

39	48

40 ## 1.0.1	49 ## 1.0.1

41	50

42 * Don't crash when mapping stack chains.	51 * Don't crash when mapping stack chains.

43	52

44 ## 1.0.0	53 ## 1.0.0

45	54

46 * Initial release.	55 * Initial release.

OLD	NEW

« no previous file with comments | « no previous file | lib/source_map_stack_trace.dart » ('j') | lib/source_map_stack_trace.dart » ('J')