Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2555223002:
[turbofan] Inlining of API functions. (Closed)
Description[turbofan] Inlining of API functions.
BUG=
Committed: https://crrev.com/2547ec872913fc5ab62d93279ae3b19708309f93
Cr-Commit-Position: refs/heads/master@{#41590}
Patch Set 1 : Removed comment. #Patch Set 2 : Update. #
Total comments: 4
Patch Set 3 : Update. #
Messages
Total messages: 24 (17 generated)
Description was changed from ========== [turbofan] Support inlining of API functions. BUG= ========== to ========== [turbofan] Inlining of API functions. BUG= ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/17528) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
epertoso@chromium.org changed reviewers: + jarin@chromium.org
lgtm (even though I do not know much about API functions). https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... File src/compiler/js-call-reducer.cc (right): https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... src/compiler/js-call-reducer.cc:269: int const argc = static_cast<int>(params.arity()) - 2; As discussed before, it would be good to describe why things are subtracted/added from arities. Could you add a line explaining where the 2 comes from? https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... src/compiler/js-call-reducer.cc:293: handle(FunctionTemplateInfo::cast(function_template_info->signature())); Hmm, signature of FunctionTemplateInfo is FunctionTemplateInfo?
https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... File src/compiler/js-call-reducer.cc (right): https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... src/compiler/js-call-reducer.cc:269: int const argc = static_cast<int>(params.arity()) - 2; On 2016/12/08 12:31:53, Jarin wrote: > As discussed before, it would be good to describe why things are > subtracted/added from arities. Could you add a line explaining where the 2 comes > from? Done here and in ReduceCallApiFunction. https://codereview.chromium.org/2555223002/diff/40001/src/compiler/js-call-re... src/compiler/js-call-reducer.cc:293: handle(FunctionTemplateInfo::cast(function_template_info->signature())); On 2016/12/08 12:31:53, Jarin wrote: > Hmm, signature of FunctionTemplateInfo is FunctionTemplateInfo? Yes. Not my fault.
The CQ bit was checked by epertoso@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2555223002/#ps60001 (title: "Update.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bmeurer@chromium.org changed reviewers: + bmeurer@chromium.org
LGTM, thanks.
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481204015156700,
"parent_rev": "2f26c9fee208f2287d21a2631741be60736b46f2", "commit_rev":
"ab12d2d667cd483db148e36f7e29cdbf2a3bed17"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Inlining of API functions. BUG= ========== to ========== [turbofan] Inlining of API functions. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Inlining of API functions. BUG= ========== to ========== [turbofan] Inlining of API functions. BUG= Committed: https://crrev.com/2547ec872913fc5ab62d93279ae3b19708309f93 Cr-Commit-Position: refs/heads/master@{#41590} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2547ec872913fc5ab62d93279ae3b19708309f93 Cr-Commit-Position: refs/heads/master@{#41590} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
