Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2555213005: [serializer] fix hash function for hashmap used for serializing. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] fix hash function for hashmap used for serializing. Yes. I thought I was being smart. And yes. It's just a one-liner. TBR=cbruni@chromium.org BUG=chromium:672009 Committed: https://crrev.com/00c82cd1badfcce85b1f12523b27e10392414fbf Cr-Commit-Position: refs/heads/master@{#41572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/address-map.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years ago (2016-12-08 07:48:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555213005/1
4 years ago (2016-12-08 07:48:26 UTC) #3
Camillo Bruni
LGTM I love when you get a 100% prediction rate on a bug without understanding ...
4 years ago (2016-12-08 07:56:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 08:14:53 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-08 08:15:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00c82cd1badfcce85b1f12523b27e10392414fbf
Cr-Commit-Position: refs/heads/master@{#41572}

Powered by Google App Engine
This is Rietveld 408576698