third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp - Issue 2555213002: Implement color management for ImageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

Issue 2555213002: Implement color management for ImageData (Closed)

Patch Set: Work in progress Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h ('K') | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h ('k') | third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl » ('j') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

diff --git a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

index f053a33e37d4afb757810137089f54b41c110043..01fcb7ebd6331f7f8711e8796f4bbdeebdcefa06 100644

--- a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

+++ b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

@@ -37,6 +37,7 @@

#include "core/frame/ImageBitmap.h"

#include "core/frame/LocalDOMWindow.h"

#include "core/frame/UseCounter.h"

+#include "core/html/Float32ImageData.h"

#include "core/html/HTMLCanvasElement.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLVideoElement.h"

@@ -91,6 +92,8 @@ static inline ImageBitmapSource* toImageBitmapSourceInternal(

return value.getAsBlob();

if (value.isImageData())

return value.getAsImageData();

+ if (value.isFloat32ImageData())

+ return value.getAsFloat32ImageData();

Justin Novosad 2016/12/08 18:16:35 should have a DCHECK on the runtim flag that expos

zakerinasab 2016/12/08 20:40:52 Done.

if (value.isImageBitmap())

return value.getAsImageBitmap();

ASSERT_NOT_REACHED();