Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2555213002: Implement color management for ImageData (Closed)
Patch Set: Rebaselining layout tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index f6ba656402cdc7ff7446b660d8daabca8a2ab30e..858f4d3fc8dc695a961ee4b902e4d5921d81ff98 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -4,6 +4,7 @@
#include "core/frame/ImageBitmap.h"
+#include "core/html/Float32ImageData.h"
#include "core/html/HTMLCanvasElement.h"
#include "core/html/HTMLVideoElement.h"
#include "core/html/ImageData.h"
@@ -757,6 +758,8 @@ static sk_sp<SkImage> scaleSkImage(sk_sp<SkImage> skImage,
resizedPixels.release().leakRef());
}
+// TODO(zakerinasab): Fix this and the constructor from Float32ImageData
+// when the CL for Float32ImageData landed.
ImageBitmap::ImageBitmap(ImageData* data,
Optional<IntRect> cropRect,
const ImageBitmapOptions& options) {
@@ -905,6 +908,10 @@ ImageBitmap::ImageBitmap(ImageData* data,
m_image = StaticBitmapImage::create(std::move(skImage));
}
+ImageBitmap::ImageBitmap(Float32ImageData* data,
+ Optional<IntRect> cropRect,
+ const ImageBitmapOptions& options) {}
+
ImageBitmap::ImageBitmap(ImageBitmap* bitmap,
Optional<IntRect> cropRect,
const ImageBitmapOptions& options) {
@@ -989,6 +996,12 @@ ImageBitmap* ImageBitmap::create(ImageData* data,
return new ImageBitmap(data, cropRect, options);
}
+ImageBitmap* ImageBitmap::create(Float32ImageData* data,
+ Optional<IntRect> cropRect,
+ const ImageBitmapOptions& options) {
+ return new ImageBitmap(data, cropRect, options);
+}
+
ImageBitmap* ImageBitmap::create(ImageBitmap* bitmap,
Optional<IntRect> cropRect,
const ImageBitmapOptions& options) {

Powered by Google App Engine
This is Rietveld 408576698