[wasm][asm.js] Utf8 encode exported function names.

[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org

Committed: https://crrev.com/c4f9e42934ee9eb7e59a3305b6735cfa2d253684
Cr-Commit-Position: refs/heads/master@{#41576}

[bradnelson, 2016-12-07 16:15:59]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 16:16:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-12-07 16:16:42]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-12-07 16:17:01]

Description was changed from

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
==========

to

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org
==========

[bradn, 2016-12-07 16:17:01]

bradnelson@google.com changed reviewers:
+ titzer@chromium.org

[titzer, 2016-12-07 16:19:18]

lgtm modulo potential memory management bugs.

https://codereview.chromium.org/2555203002/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2555203002/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:719: std::unique_ptr<char[]> utf8 =
function_name->ToCString(
Mmmm, I think this might be a dangling reference...I think you need to allocate
space in the zone for this.

[commit-bot: I haz the power, 2016-12-07 16:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:40:02]

Dry run: This issue passed the CQ dry run.

[bradn, 2016-12-08 08:50:24]

https://codereview.chromium.org/2555203002/diff/1/src/asmjs/asm-wasm-builder.cc
File src/asmjs/asm-wasm-builder.cc (right):

https://codereview.chromium.org/2555203002/diff/1/src/asmjs/asm-wasm-builder....
src/asmjs/asm-wasm-builder.cc:719: std::unique_ptr<char[]> utf8 =
function_name->ToCString(
On 2016/12/07 16:19:18, titzer wrote:
> Mmmm, I think this might be a dangling reference...I think you need to
allocate
> space in the zone for this.

ExportAs converts the Vector<char> to a ZoneVector<char> and at that point makes
a copy into the zone for the one it keeps inside. So this should be fine.

[bradn, 2016-12-08 08:50:29]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-12-08 08:50:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481187029064120, "parent_rev":
"7b8e1d0f218d1116d7c9e531acee25194e25b82e", "commit_rev":
"f02939599378c4072d76797d152d41f7a9142e33"}

[commit-bot: I haz the power, 2016-12-08 08:52:37]

Description was changed from

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org
==========

to

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-12-08 08:52:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-08 08:53:00]

Description was changed from

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org
==========

to

==========
[wasm][asm.js] Utf8 encode exported function names.

BUG=672047
R=titzer@chromium.org

Committed: https://crrev.com/c4f9e42934ee9eb7e59a3305b6735cfa2d253684
Cr-Commit-Position: refs/heads/master@{#41576}
==========

[commit-bot: I haz the power, 2016-12-08 08:53:01]

Patchset 1 (id:??) landed as
https://crrev.com/c4f9e42934ee9eb7e59a3305b6735cfa2d253684
Cr-Commit-Position: refs/heads/master@{#41576}