Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Side by Side Diff: src/objects.cc

Issue 255513005: Make DescriptorArray::IsMoreGeneralThan() and DescriptorArray::Merge() compatible again. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-365172-1.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8502 matching lines...) Expand 10 before | Expand all | Expand 10 after
8513 8513
8514 for (int descriptor = verbatim; descriptor < valid; descriptor++) { 8514 for (int descriptor = verbatim; descriptor < valid; descriptor++) {
8515 PropertyDetails details = GetDetails(descriptor); 8515 PropertyDetails details = GetDetails(descriptor);
8516 PropertyDetails other_details = other->GetDetails(descriptor); 8516 PropertyDetails other_details = other->GetDetails(descriptor);
8517 if (!other_details.representation().fits_into(details.representation())) { 8517 if (!other_details.representation().fits_into(details.representation())) {
8518 return false; 8518 return false;
8519 } 8519 }
8520 if (details.type() == CONSTANT) { 8520 if (details.type() == CONSTANT) {
8521 if (other_details.type() != CONSTANT) return false; 8521 if (other_details.type() != CONSTANT) return false;
8522 if (GetValue(descriptor) != other->GetValue(descriptor)) return false; 8522 if (GetValue(descriptor) != other->GetValue(descriptor)) return false;
8523 } else if (details.type() == FIELD && other_details.type() == FIELD) {
8524 if (!other->GetFieldType(descriptor)->NowIs(GetFieldType(descriptor))) {
8525 return false;
8526 }
8523 } 8527 }
8524 } 8528 }
8525 8529
8526 return true; 8530 return true;
8527 } 8531 }
8528 8532
8529 8533
8530 // We need the whiteness witness since sort will reshuffle the entries in the 8534 // We need the whiteness witness since sort will reshuffle the entries in the
8531 // descriptor array. If the descriptor array were to be black, the shuffling 8535 // descriptor array. If the descriptor array were to be black, the shuffling
8532 // would move a slot that was already recorded as pointing into an evacuation 8536 // would move a slot that was already recorded as pointing into an evacuation
(...skipping 8895 matching lines...) Expand 10 before | Expand all | Expand 10 after
17428 #define ERROR_MESSAGES_TEXTS(C, T) T, 17432 #define ERROR_MESSAGES_TEXTS(C, T) T,
17429 static const char* error_messages_[] = { 17433 static const char* error_messages_[] = {
17430 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 17434 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
17431 }; 17435 };
17432 #undef ERROR_MESSAGES_TEXTS 17436 #undef ERROR_MESSAGES_TEXTS
17433 return error_messages_[reason]; 17437 return error_messages_[reason];
17434 } 17438 }
17435 17439
17436 17440
17437 } } // namespace v8::internal 17441 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-365172-1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698