Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255513004: MTPFileStreamReader::Read should return 0 instead of error on read-from-eof. (Closed)

Created:
6 years, 8 months ago by kinaba
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

MTPFileStreamReader::Read should return 0 instead of error on read-from-eof. BUG=366504 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/media_galleries/linux/mtp_device_task_helper.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
kinaba
PTAL.
6 years, 8 months ago (2014-04-24 05:43:00 UTC) #1
Lei Zhang
lgtm
6 years, 8 months ago (2014-04-24 06:26:18 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 8 months ago (2014-04-24 06:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/255513004/1
6 years, 8 months ago (2014-04-24 06:27:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 08:27:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 08:27:37 UTC) #6
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 8 months ago (2014-04-24 09:49:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/255513004/1
6 years, 8 months ago (2014-04-24 10:03:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:18:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 14:18:27 UTC) #10
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 8 months ago (2014-04-25 00:17:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/255513004/1
6 years, 8 months ago (2014-04-25 00:17:57 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 00:25:36 UTC) #13
Message was sent while issue was closed. 
Change committed as 266070

Powered by Google App Engine
This is Rietveld 408576698