Remove ContextLifecycleObserver from ScopedWindowFocusAllowedIndicator

Remove ContextLifecycleObserver from ScopedWindowFocusAllowedIndicator

- This CL removes ScopedWindowFocusAllowedIndicator::Observer
since the observer indirection is unnecessary.

- This CL makes ScopedWindowFocusAllowedIndicator hold a strong member
to ExecutionContext and removes ContextLifecycleObserver.

BUG=610176
Committed: https://crrev.com/7dc9259ff40eeb462367161ead5ab28ab9aa9d23
Cr-Commit-Position: refs/heads/master@{#436898}

[haraken, 2016-12-07 07:49:17]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-12-07 07:49:17]

PTAL

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
(left):

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:44: // to
call getExecutionContext()->consumeWindowInteraction().

I don't understand this comment. The observer indirection is just not needed,
right?

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
(right):

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:29: // is
used only on a machine stack.

But we cannot use STACK_ALLOCATED because the object is exposed to content/ via
WebPrivatePtr. (The content/ uses this object on stack in essence.)

[sof, 2016-12-07 08:02:18]

lgtm

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
(left):

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:44: // to
call getExecutionContext()->consumeWindowInteraction().
On 2016/12/07 07:49:17, haraken wrote:
> 
> I don't understand this comment. The observer indirection is just not needed,
> right?

We need(ed) to inject an on-heap ContextLifecycleObserver in some way, so I do
think it was needed without shortening out the ExecutionContext, like you've
done now.

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
(right):

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:8:
#include "core/dom/ContextLifecycleObserver.h"
unused

https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:29: // is
used only on a machine stack.
On 2016/12/07 07:49:17, haraken wrote:
> 
> But we cannot use STACK_ALLOCATED because the object is exposed to content/
via
> WebPrivatePtr. (The content/ uses this object on stack in essence.)

Having a Persistent<ExecutionContext> is scary (wrt leaking), but no different
to what we had previously.

[haraken, 2016-12-07 08:07:56]

On 2016/12/07 08:02:18, sof wrote:
> lgtm
> 
>
https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
> (left):
> 
>
https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:44: //
to
> call getExecutionContext()->consumeWindowInteraction().
> On 2016/12/07 07:49:17, haraken wrote:
> > 
> > I don't understand this comment. The observer indirection is just not
needed,
> > right?
> 
> We need(ed) to inject an on-heap ContextLifecycleObserver in some way, so I do
> think it was needed without shortening out the ExecutionContext, like you've
> done now.

ah, thanks. Makes sense.

> 
>
https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
> (right):
> 
>
https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:8:
> #include "core/dom/ContextLifecycleObserver.h"
> unused

Fixed.

> 
>
https://codereview.chromium.org/2555113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h:29: //
is
> used only on a machine stack.
> On 2016/12/07 07:49:17, haraken wrote:
> > 
> > But we cannot use STACK_ALLOCATED because the object is exposed to content/
> via
> > WebPrivatePtr. (The content/ uses this object on stack in essence.)
> 
> Having a Persistent<ExecutionContext> is scary (wrt leaking), but no different
> to what we had previously.

[haraken, 2016-12-07 08:07:59]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-12-07 08:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2555113002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-12-07 08:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 09:37:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481098079952370,
"parent_rev": "1794b840474e2c9746572770ec155a7cf9d51ae4", "commit_rev":
"e00843c54f19bd084d730756947502e9e2e96a53"}

[commit-bot: I haz the power, 2016-12-07 09:38:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 09:40:29]

Description was changed from

==========
Remove ContextLifecycleObserver from ScopedWindowFocusAllowedIndicator

- This CL removes ScopedWindowFocusAllowedIndicator::Observer
since the observer indirection is unnecessary.

- This CL makes ScopedWindowFocusAllowedIndicator hold a strong member
to ExecutionContext and removes ContextLifecycleObserver.

BUG=610176
==========

to

==========
Remove ContextLifecycleObserver from ScopedWindowFocusAllowedIndicator

- This CL removes ScopedWindowFocusAllowedIndicator::Observer
since the observer indirection is unnecessary.

- This CL makes ScopedWindowFocusAllowedIndicator hold a strong member
to ExecutionContext and removes ContextLifecycleObserver.

BUG=610176

Committed: https://crrev.com/7dc9259ff40eeb462367161ead5ab28ab9aa9d23
Cr-Commit-Position: refs/heads/master@{#436898}
==========

[commit-bot: I haz the power, 2016-12-07 09:40:30]

Patchset 2 (id:??) landed as
https://crrev.com/7dc9259ff40eeb462367161ead5ab28ab9aa9d23
Cr-Commit-Position: refs/heads/master@{#436898}