Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2555103004: ImageResource: remove unnecessary vector copying during iteration. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
tkent, hiroshige, yhirano
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageResource: remove unnecessary vector copying during iteration. Iterations that don't update the underlying collection, can be done in-place. R= BUG= Committed: https://crrev.com/af6993cee55aaf307b3f73e4e0ca5f05aa0413f4 Cr-Commit-Position: refs/heads/master@{#437482}

Patch Set 1 #

Patch Set 2 : remove redundant hash table lookups #

Patch Set 3 : add comments #

Total comments: 2

Patch Set 4 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 5 chunks +25 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceObserver.h View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 48 (21 generated)
sof
please take a look. I've been trying to understand these asVector() uses for a while, ...
4 years ago (2016-12-07 09:11:42 UTC) #6
tkent
+yhirano On 2016/12/07 at 09:11:42, sigbjornf wrote: > I've been trying to understand these asVector() ...
4 years ago (2016-12-07 23:38:43 UTC) #10
yhirano
On 2016/12/07 23:38:43, tkent wrote: > +yhirano > > On 2016/12/07 at 09:11:42, sigbjornf wrote: ...
4 years ago (2016-12-08 01:59:49 UTC) #11
sof
On 2016/12/08 01:59:49, yhirano wrote: > On 2016/12/07 23:38:43, tkent wrote: > > +yhirano > ...
4 years ago (2016-12-08 06:30:50 UTC) #12
yhirano
On 2016/12/08 06:30:50, sof wrote: > On 2016/12/08 01:59:49, yhirano wrote: > > On 2016/12/07 ...
4 years ago (2016-12-08 06:50:05 UTC) #13
sof
On 2016/12/08 06:50:05, yhirano wrote: > On 2016/12/08 06:30:50, sof wrote: > > On 2016/12/08 ...
4 years ago (2016-12-08 07:09:59 UTC) #14
yhirano
On 2016/12/08 07:09:59, sof wrote: > On 2016/12/08 06:50:05, yhirano wrote: > > On 2016/12/08 ...
4 years ago (2016-12-08 07:14:34 UTC) #15
sof
On 2016/12/08 07:14:34, yhirano wrote: > On 2016/12/08 07:09:59, sof wrote: > > On 2016/12/08 ...
4 years ago (2016-12-08 07:27:03 UTC) #16
yhirano
https://codereview.chromium.org/2555103004/diff/40001/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h File third_party/WebKit/Source/core/fetch/ImageResourceObserver.h (right): https://codereview.chromium.org/2555103004/diff/40001/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h#newcode63 third_party/WebKit/Source/core/fetch/ImageResourceObserver.h:63: virtual ResourcePriority computeResourcePriority() const { This function has the ...
4 years ago (2016-12-08 07:29:21 UTC) #17
sof
https://codereview.chromium.org/2555103004/diff/40001/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h File third_party/WebKit/Source/core/fetch/ImageResourceObserver.h (right): https://codereview.chromium.org/2555103004/diff/40001/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h#newcode63 third_party/WebKit/Source/core/fetch/ImageResourceObserver.h:63: virtual ResourcePriority computeResourcePriority() const { On 2016/12/08 07:29:21, yhirano ...
4 years ago (2016-12-08 07:32:51 UTC) #18
yhirano
lgtm
4 years ago (2016-12-08 07:34:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-08 07:34:49 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82108)
4 years ago (2016-12-08 08:56:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-08 09:03:08 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82148)
4 years ago (2016-12-08 10:37:28 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-08 10:45:17 UTC) #29
hiroshige
lgtm. I think we should add assertions that these callbacks actually does not add/remove observers, ...
4 years ago (2016-12-08 10:46:01 UTC) #30
sof
On 2016/12/08 10:46:01, hiroshige wrote: > lgtm. I think we should add assertions that these ...
4 years ago (2016-12-08 10:52:51 UTC) #31
sof
On 2016/12/08 10:52:51, sof wrote: > On 2016/12/08 10:46:01, hiroshige wrote: > > lgtm. I ...
4 years ago (2016-12-08 11:00:18 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82171)
4 years ago (2016-12-08 12:06:26 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-08 14:34:01 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82294)
4 years ago (2016-12-08 15:54:03 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-08 16:24:02 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82355)
4 years ago (2016-12-08 17:55:06 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103004/60001
4 years ago (2016-12-09 06:15:25 UTC) #44
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-09 06:21:56 UTC) #46
commit-bot: I haz the power
4 years ago (2016-12-09 06:24:25 UTC) #48
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/af6993cee55aaf307b3f73e4e0ca5f05aa0413f4
Cr-Commit-Position: refs/heads/master@{#437482}

Powered by Google App Engine
This is Rietveld 408576698