Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2555103003: Made empty-cells property independent. (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
napper, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made empty-cells property independent. Made empty-cells property independent. Also updated independent-inheritance-fast-path.html to include emptyCells. Tested using independent-inheritance-fast-path.html. BUG=628043 Committed: https://crrev.com/7c4945f1f56993bbeec9cf73141d1d5ccf932061 Cr-Commit-Position: refs/heads/master@{#437434}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
sashab
I love these patches!! \o/ \o/ \o/
4 years ago (2016-12-07 06:26:43 UTC) #2
napper
lgtm
4 years ago (2016-12-07 22:24:02 UTC) #3
sashab
4 years ago (2016-12-07 22:35:08 UTC) #5
nainar
lgtm
4 years ago (2016-12-07 22:36:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103003/1
4 years ago (2016-12-07 22:50:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81597)
4 years ago (2016-12-08 00:20:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555103003/20001
4 years ago (2016-12-09 00:24:40 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 02:20:40 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-09 02:23:01 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c4945f1f56993bbeec9cf73141d1d5ccf932061
Cr-Commit-Position: refs/heads/master@{#437434}

Powered by Google App Engine
This is Rietveld 408576698