Render extension URLs with chips

chrome/browser/ui/location_bar/location_bar.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 #define CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 
 #include <stddef.h>
 
 #include "base/macros.h"
@@ skipping 86 matching lines @@
   virtual LocationBarTesting* GetLocationBarForTesting() = 0;
 
   Profile* profile() { return profile_; }
 
  protected:
   virtual ~LocationBar();
 
   // Checks if any extension has requested that the bookmark star be hidden.
   bool IsBookmarkStarHiddenByExtension() const;
 
+  // Returns the name of the extension associated with the page, if any.
+  // Returns empty string otherwise. Performs basic sanitization on the
+  // extension name.

[Peter Kasting, 2016/12/14 22:47:07]

Nit: "associated with the page" is kinda vague; if a content script is acting on
a page, is that "associated"?  Maybe say "If |url| is an extension URL, returns
the name of the associated extension, with whitespace collapsed.  |web_contents|
is used to get at the extension registry."

[meacer, 2016/12/16 18:46:17]

Done.

+  base::string16 GetExtensionName(const GURL& url,
+                                  content::WebContents* web_contents) const;

[Peter Kasting, 2016/12/14 22:47:07]

It seems like this method can be static, not just const.

[meacer, 2016/12/16 18:46:17]

Done.

+
  private:
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBar);
 };
 
 class LocationBarTesting {
  public:
   // Returns the total number of page actions in the Omnibox.
   virtual int PageActionCount() = 0;
@@ skipping 11 matching lines @@
   virtual void TestPageActionPressed(size_t index) = 0;
 
   // Returns whether or not the bookmark star decoration is visible.
   virtual bool GetBookmarkStarVisibility() = 0;
 
  protected:
   virtual ~LocationBarTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_