Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2555063002: Fix missing namespace for scoped_nsobject. (Closed)

Created:
4 years ago by carlosk
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing namespace for scoped_nsobject. Added missing base:: namespace prefix. BUG=671842 TBR=noyau@chromium.org,eugenebut@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c65594c7b4f150e8a2854991a82bcdc19eb8c47a Cr-Commit-Position: refs/heads/master@{#436771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555063002/1
4 years ago (2016-12-06 23:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555063002/1
4 years ago (2016-12-07 00:14:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 00:15:08 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c65594c7b4f150e8a2854991a82bcdc19eb8c47a Cr-Commit-Position: refs/heads/master@{#436771}
4 years ago (2016-12-07 00:17:27 UTC) #11
noyau (Ping after 24h)
On 2016/12/07 00:17:27, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years ago (2016-12-07 11:57:06 UTC) #12
carlosk
On 2016/12/07 11:57:06, noyau wrote: > On 2016/12/07 00:17:27, commit-bot: I haz the power wrote: ...
4 years ago (2016-12-07 17:52:45 UTC) #13
carlosk
4 years ago (2016-12-07 17:53:41 UTC) #15
Message was sent while issue was closed.
Just directly including the post-commit reviewers. I'm not sure you are notified
with only the TBR label that I added.

Powered by Google App Engine
This is Rietveld 408576698