Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: ui/base/BUILD.gn

Issue 2555033003: Add ScopedMacRTL class for Cocoa browser RTL testing (Closed)
Patch Set: Whitespace Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index cbb826e348fd1a69dbd43d26cb1de69128ac03c3..462d4b9ad4455e694110f402439440e1270f1357 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -126,6 +126,8 @@ component("base") {
"cocoa/nsview_additions.mm",
"cocoa/remote_layer_api.h",
"cocoa/remote_layer_api.mm",
+ "cocoa/rtl_feature.h",
+ "cocoa/rtl_feature.mm",
"cocoa/scoped_cg_context_smooth_fonts.h",
"cocoa/scoped_cg_context_smooth_fonts.mm",
"cocoa/three_part_image.h",
@@ -657,12 +659,6 @@ static_library("test_support") {
]
}
- if (is_mac) {
- sources += [ "test/user_interactive_test_case_mac.mm" ]
- } else {
- sources += [ "test/user_interactive_test_case.cc" ]
- }
-
public_deps = [
":base",
]
@@ -678,6 +674,21 @@ static_library("test_support") {
"//ui/gfx/geometry",
]
+ if (is_mac) {
+ sources += [
+ "test/scoped_mac_rtl.h",
+ "test/scoped_mac_rtl.mm",
tapted 2016/12/07 23:20:27 (maybe it's historical but..) the current conventi
+ "test/user_interactive_test_case_mac.mm",
+ ]
+
+ deps += [
+ "//base:i18n",
+ "//base/test:test_support",
+ ]
+ } else {
+ sources += [ "test/user_interactive_test_case.cc" ]
+ }
+
if (build_ime) {
sources += [
"ime/dummy_input_method.cc",

Powered by Google App Engine
This is Rietveld 408576698