Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/ui/cocoa/framed_browser_window.mm

Issue 2555033003: Add ScopedMacRTL class for Cocoa browser RTL testing (Closed)
Patch Set: Review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/framed_browser_window.mm
diff --git a/chrome/browser/ui/cocoa/framed_browser_window.mm b/chrome/browser/ui/cocoa/framed_browser_window.mm
index 65e14a23e2979575da4ec570af4bf26dacbcaae7..8a95150ebaf6677c936934befb056478ee0eab72 100644
--- a/chrome/browser/ui/cocoa/framed_browser_window.mm
+++ b/chrome/browser/ui/cocoa/framed_browser_window.mm
@@ -17,13 +17,13 @@
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
#import "chrome/browser/ui/cocoa/browser_window_layout.h"
#import "chrome/browser/ui/cocoa/browser_window_utils.h"
-#include "chrome/browser/ui/cocoa/l10n_util.h"
#import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
#import "chrome/browser/ui/cocoa/themed_window.h"
#include "chrome/grit/theme_resources.h"
#include "ui/base/cocoa/cocoa_base_utils.h"
#include "ui/base/cocoa/nsgraphics_context_additions.h"
#import "ui/base/cocoa/nsview_additions.h"
+#import "ui/base/cocoa/rtl_feature.h"
#include "ui/base/material_design/material_design_controller.h"
// Implementer's note: Moving the window controls is tricky. When altering the
@@ -275,7 +275,7 @@ const CGFloat kWindowGradientHeight = 24.0;
// should determine if current locale is RTL.
NSLayoutXAxisAnchor* leadingSourceAnchor = [button leftAnchor];
NSLayoutXAxisAnchor* leadingTargetAnchor = [[button superview] leftAnchor];
- if (cocoa_l10n_util::ShouldFlipWindowControlsInRTL()) {
+ if (ui::ShouldFlipWindowControlsInRTL()) {
leadingSourceAnchor = [button rightAnchor];
leadingTargetAnchor = [[button superview] rightAnchor];
leadingOffset = -leadingOffset;
@@ -338,7 +338,7 @@ const CGFloat kWindowGradientHeight = 24.0;
break;
}
- if (cocoa_l10n_util::ShouldFlipWindowControlsInRTL()) {
+ if (ui::ShouldFlipWindowControlsInRTL()) {
buttonFrame.origin.x =
NSWidth([self frame]) - buttonFrame.origin.x - NSWidth([button frame]);
}

Powered by Google App Engine
This is Rietveld 408576698