Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: ui/base/cocoa/rtl_feature.h

Issue 2555033003: Add ScopedMacRTL class for Cocoa browser RTL testing (Closed)
Patch Set: Review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_BASE_COCOA_RTL_FEATURE_H_
6 #define UI_BASE_COCOA_RTL_FEATURE_H_
7
8 #include "base/feature_list.h"
9 #include "ui/base/ui_base_export.h"
10
11 namespace ui {
12
13 UI_BASE_EXPORT extern const base::Feature kExperimentalMacRTL;
Robert Sesek 2016/12/07 19:21:01 nit: blank line after
lgrey 2016/12/07 19:34:21 Done.
14 // Returns whether both:
15 // 1) Experimental Mac RTL support is enabled via the ExperimentalMacRTL
16 // feature;
17 // 2) The browser UI is in RTL mode.
18 // If ExperimentalMacRTL becomes the default, this function can be replaced with
19 // uses of base::i18n::IsRTL().
20 UI_BASE_EXPORT bool ShouldDoExperimentalRTLLayout();
21
22 // Returns true if ShouldDoExperimentalRTLLayout() is true and the OS is
23 // 10.12 or above. macOS 10.12 is the first OS where the native stoplight
24 // buttons are reversed in RTL, so manually reversing them in previous
25 // OSes would make Chrome stick out.
26 UI_BASE_EXPORT bool ShouldFlipWindowControlsInRTL();
27
28 } // namespace ui
Robert Sesek 2016/12/07 19:21:01 nit: blank line after
lgrey 2016/12/07 19:34:21 Done.
29 #endif // UI_BASE_COCOA_RTL_FEATURE_H_
OLDNEW
« no previous file with comments | « ui/base/BUILD.gn ('k') | ui/base/cocoa/rtl_feature.mm » ('j') | ui/base/cocoa/rtl_feature.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698