Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2555023002: Merged: [promises] Set promise context's closure to be an empty function (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
neis, adamk
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [promises] Set promise context's closure to be an empty function Revision: a29b658eec3324716e39d44add188499f298c590 BUG=chromium:666984 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=neis@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/promise-utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gsathya
4 years ago (2016-12-06 20:06:46 UTC) #1
gsathya
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-12-06 20:06:47 UTC) #2
adamk
lgtm
4 years ago (2016-12-06 20:10:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555023002/1
4 years ago (2016-12-06 20:15:22 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-06 20:15:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698