third_party/WebKit/Source/modules/permissions/Permissions.cpp - Issue 2555013004: UserGestureIndicator: remove many unnecessary calls to isMainThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 2555013004: UserGestureIndicator: remove many unnecessary calls to isMainThread (Closed)

Patch Set: Avoid duplicate thread checks in DOMTimer Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp

diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

index 873b44520749102caae9f42094ff8fb01192500a..0050013db8919787b071ff6cb332b49882c40a72 100644

--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp

+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

@@ -156,7 +156,7 @@ ScriptPromise Permissions::request(ScriptState* scriptState,

service->RequestPermission(

std::move(descriptor),

scriptState->getExecutionContext()->getSecurityOrigin(),

- UserGestureIndicator::processingUserGesture(),

+ UserGestureIndicator::processingUserGestureThreadSafe(),

convertToBaseCallback(WTF::bind(

&Permissions::taskComplete, wrapPersistent(this),

wrapPersistent(resolver), WTF::passed(std::move(descriptorCopy)))));

@@ -247,7 +247,7 @@ ScriptPromise Permissions::requestAll(

service->RequestPermissions(

std::move(internalPermissions),

scriptState->getExecutionContext()->getSecurityOrigin(),

- UserGestureIndicator::processingUserGesture(),

+ UserGestureIndicator::processingUserGestureThreadSafe(),

convertToBaseCallback(

WTF::bind(&Permissions::batchTaskComplete, wrapPersistent(this),

wrapPersistent(resolver),