Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2555003002: DevTools: Sources: Evaluate selected text should be Ctrl+Shift+E (Closed)

Created:
4 years ago by einbinder
Modified:
4 years ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Sources: Evaluate selected text should be Ctrl+Shift+E It was mistakenly assigned to Ctrl+E. BUG=658989 Committed: https://crrev.com/359a23a93846ccadce7435394771ef9d14d0d2c6 Cr-Commit-Position: refs/heads/master@{#436798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
einbinder
ptal
4 years ago (2016-12-06 19:26:17 UTC) #2
dgozman
lgtm
4 years ago (2016-12-06 20:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555003002/1
4 years ago (2016-12-06 20:59:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 00:54:35 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 00:56:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/359a23a93846ccadce7435394771ef9d14d0d2c6
Cr-Commit-Position: refs/heads/master@{#436798}

Powered by Google App Engine
This is Rietveld 408576698