Created methods to surface zone memory information for each isolate and thread in JSON.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/globals.h"
 
@@ skipping 3740 matching lines @@
   jsobj.AddProperty("minor",
                     static_cast<intptr_t>(SERVICE_PROTOCOL_MINOR_VERSION));
   jsobj.AddProperty("_privateMajor", static_cast<intptr_t>(0));
   jsobj.AddProperty("_privateMinor", static_cast<intptr_t>(0));
   return true;
 }
 
 
 class ServiceIsolateVisitor : public IsolateVisitor {
  public:
-  explicit ServiceIsolateVisitor(JSONArray* jsarr) : jsarr_(jsarr) {}
+  explicit ServiceIsolateVisitor(JSONArray* jsarr, bool ref = true)

[zra, 2016/12/08 18:54:13]

Unless I'm missing something, this class only has one instantiation, so I think
we don't need to use an optional argument here.

[bkonyi, 2016/12/08 20:58:32]

You're right, it's only instantiated once. I've removed the ref parameter since
it should always be false given the implementation of PrintJSONForVM

+      : jsarr_(jsarr), ref_(ref) {}
 
   virtual ~ServiceIsolateVisitor() {}
 
   void VisitIsolate(Isolate* isolate) {
     if ((isolate != Dart::vm_isolate()) &&
         !ServiceIsolate::IsServiceIsolateDescendant(isolate)) {
-      jsarr_->AddValue(isolate);
+      jsarr_->AddValue(isolate, ref_);
     }
   }
 
  private:
   JSONArray* jsarr_;
+  bool ref_;
 };
 
 
 static const MethodParameter* get_vm_params[] = {
     NO_ISOLATE_PARAMETER, NULL,
 };
 
 
 void Service::PrintJSONForVM(JSONStream* js, bool ref) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", (ref ? "@VM" : "VM"));
   jsobj.AddProperty("name", GetVMName());
   if (ref) {
     return;
   }
   Isolate* vm_isolate = Dart::vm_isolate();
   jsobj.AddProperty("architectureBits", static_cast<intptr_t>(kBitsPerWord));
   jsobj.AddProperty("targetCPU", CPU::Id());
   jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());
   jsobj.AddProperty("version", Version::String());
   jsobj.AddProperty("_profilerMode", FLAG_profile_vm ? "VM" : "Dart");
   jsobj.AddProperty64("pid", OS::ProcessId());
   jsobj.AddProperty64("_maxRSS", OS::MaxRSS());
   int64_t start_time_millis =
       (vm_isolate->start_time() / kMicrosecondsPerMillisecond);
   jsobj.AddPropertyTimeMillis("startTime", start_time_millis);
   // Construct the isolate list.
   {
     JSONArray jsarr(&jsobj, "isolates");
-    ServiceIsolateVisitor visitor(&jsarr);
+    ServiceIsolateVisitor visitor(&jsarr, ref);
     Isolate::VisitIsolates(&visitor);
   }
 }
 
 
 static bool GetVM(Thread* thread, JSONStream* js) {
   Service::PrintJSONForVM(js, false);
   return true;
 }
 
@@ skipping 311 matching lines @@
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart