runtime/vm/isolate_test.cc - Issue 2554983002: Created methods to surface zone memory information for each isolate and thread in JSON.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/isolate_test.cc

Issue 2554983002: Created methods to surface zone memory information for each isolate and thread in JSON. (Closed)

Patch Set: Created methods to surface zone memory information for each isolate and thread in JSON. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/json_stream.h » ('j') | runtime/vm/json_stream.cc » ('J')

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "include/dart_api.h"	5 #include "include/dart_api.h"

6 #include "platform/assert.h"	6 #include "platform/assert.h"

7 #include "vm/globals.h"	7 #include "vm/globals.h"

8 #include "vm/isolate.h"	8 #include "vm/isolate.h"

9 #include "vm/lockers.h"	9 #include "vm/lockers.h"

10 #include "vm/thread_barrier.h"	10 #include "vm/thread_barrier.h"

(...skipping 227 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
238 }	238 }

239	239

240 // Restore, then clear interrupts. The world is as it was.	240 // Restore, then clear interrupts. The world is as it was.

241 interrupt_bits = thread->GetAndClearInterrupts();	241 interrupt_bits = thread->GetAndClearInterrupts();

242 EXPECT_EQ(kMessageInterrupt, interrupt_bits);	242 EXPECT_EQ(kMessageInterrupt, interrupt_bits);

243 EXPECT_EQ(IsolateTestHelper::GetStackLimit(thread),	243 EXPECT_EQ(IsolateTestHelper::GetStackLimit(thread),

244 IsolateTestHelper::GetSavedStackLimit(thread));	244 IsolateTestHelper::GetSavedStackLimit(thread));

245 EXPECT_EQ(kZero, IsolateTestHelper::GetDeferredInterruptsMask(thread));	245 EXPECT_EQ(kZero, IsolateTestHelper::GetDeferredInterruptsMask(thread));

246 EXPECT_EQ(kZero, IsolateTestHelper::GetDeferredInterrupts(thread));	246 EXPECT_EQ(kZero, IsolateTestHelper::GetDeferredInterrupts(thread));

247 }	247 }

248
zra 2016/12/08 18:54:13 Did clang-format remove this? I think we usually k Did clang-format remove this? I think we usually keep a space after a function here. bkonyi 2016/12/08 20:58:32 I must have accidentally removed it when I deleted Show quoted text On 2016/12/08 18:54:13, zra wrote: > Did clang-format remove this? I think we usually keep a space after a function > here. I must have accidentally removed it when I deleted some tests I had written that weren't useful. I'll add it back.
249 } // namespace dart	248 } // namespace dart

OLD	NEW