Created methods to surface zone memory information for each isolate and thread in JSON.

runtime/vm/thread.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread.h"
 
 #include "vm/compiler_stats.h"
 #include "vm/dart_api_state.h"
 #include "vm/growable_array.h"
 #include "vm/isolate.h"
+#include "vm/json_stream.h"
 #include "vm/lockers.h"
 #include "vm/log.h"
 #include "vm/message_handler.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/os_thread.h"
 #include "vm/profiler.h"
 #include "vm/runtime_entry.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
@@ skipping 177 matching lines @@
 #undef INIT_VALUE
 
 // Setup the thread specific reusable handles.
 #define REUSABLE_HANDLE_ALLOCATION(object)                                     \
   this->object##_handle_ = this->AllocateReusableHandle<object>();
   REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_ALLOCATION)
 #undef REUSABLE_HANDLE_ALLOCATION
 }
 
 
+#ifndef RELEASE

[Cutch, 2016/12/06 19:11:15]

dito

[bkonyi, 2016/12/08 18:04:14]

Done.

+// Collect information about each individual zone associated with this thread.
+void Thread::PrintToJSONObject(JSONObject* obj) {
+  intptr_t size = 0;
+  Zone* zone = zone_;
+  while (zone != NULL) {
+    size += zone->SizeInBytes();
+    zone = zone->previous();
+  }
+  obj->AddPropertyF("thread_address", "0x%" Px "",

[Cutch, 2016/12/06 19:11:15]

we use dartCamelCase for service protocol property names.

Not sure why we are printing the thread address here.

[bkonyi, 2016/12/08 18:04:14]

Done.

+                    reinterpret_cast<uword>(this));
+  obj->AddPropertyF("thread_zone_size_total", "%ld", size);
+  {
+    JSONArray zone_info_array(obj, "zones");
+    zone = zone_;
+    while (zone != NULL) {
+      JSONObject zone_obj(&zone_info_array);
+      zone->PrintToJSONObject(&zone_obj);
+      zone = zone->previous();
+    }
+  }
+}
+#endif
+
+
 RawGrowableObjectArray* Thread::pending_functions() {
   if (pending_functions_ == GrowableObjectArray::null()) {
     pending_functions_ = GrowableObjectArray::New(Heap::kOld);
   }
   return pending_functions_;
 }
 
 
 void Thread::clear_pending_functions() {
   pending_functions_ = GrowableObjectArray::null();
@@ skipping 555 matching lines @@
 
 DisableThreadInterruptsScope::~DisableThreadInterruptsScope() {
   if (thread() != NULL) {
     OSThread* os_thread = thread()->os_thread();
     ASSERT(os_thread != NULL);
     os_thread->EnableThreadInterrupts();
   }
 }
 
 }  // namespace dart