Created methods to surface zone memory information for each isolate and thread in JSON.

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
 #include "platform/text_buffer.h"
@@ skipping 2073 matching lines @@
     if (!handlers.IsNull()) {
       JSONArray extensions(&jsobj, "extensionRPCs");
       String& handler_name = String::Handle();
       for (intptr_t i = 0; i < handlers.Length(); i += kRegisteredEntrySize) {
         handler_name ^= handlers.At(i + kRegisteredNameIndex);
         extensions.AddValue(handler_name.ToCString());
       }
     }
   }
 }
+
+
+void Isolate::PrintThreadsInfoToJSONObject(JSONObject* obj) {
+  obj->AddPropertyF("isolate_address", "0x%" Px "",
+                    reinterpret_cast<uword>(this));

[siva, 2016/12/07 22:12:52]

Can we use isolate id instead of isolate address here. I think the service
protocol uses isolate ids to track isolates.

[bkonyi, 2016/12/08 18:04:14]

Yes, I've gone ahead and switched from addresses to ids for isolates and
threads.

+  ASSERT(thread_registry_ != NULL);
+  thread_registry_->PrintToJSONObjectLocked(obj);
+}
 #endif
 
 
 void Isolate::set_tag_table(const GrowableObjectArray& value) {
   tag_table_ = value.raw();
 }
 
 
 void Isolate::set_current_tag(const UserTag& tag) {
   uword user_tag = tag.tag();
@@ skipping 377 matching lines @@
       return;
     }
     previous = current;
     current = current->next_;
   }
   // If we are shutting down the VM, the isolate may not be in the list.
   ASSERT(!creation_enabled_);
 }
 
 
+#ifndef RELEASE
+void Isolate::PrintAllIsolatesMemoryInfoToJSONLocked(JSONStream* stream) {

[Cutch, 2016/12/06 19:11:14]

The suffix of 'Locked' is usually applied to functions which assume the lock is
already taken. I would recommend dropping the 'Locked' suffix.

[bkonyi, 2016/12/08 18:04:13]

Done.

+  MonitorLocker ml(isolates_list_monitor_);
+  JSONArray arr(stream);
+  Isolate* current = isolates_list_head_;
+  while (current != NULL) {

[Cutch, 2016/12/06 19:11:14]

Please use Isolates::VisitIsolates instead of walking the list yourself.  It
also takes care of the locking too.

[bkonyi, 2016/12/08 18:04:14]

Done.

+    JSONObject isolate_obj(&arr);
+    current->PrintThreadsInfoToJSONObject(&isolate_obj);
+    current = current->next_;
+  }
+}
+#endif
+
+
 void Isolate::DisableIsolateCreation() {
   MonitorLocker ml(isolates_list_monitor_);
   creation_enabled_ = false;
 }
 
 
 void Isolate::EnableIsolateCreation() {
   MonitorLocker ml(isolates_list_monitor_);
   creation_enabled_ = true;
 }
@@ skipping 435 matching lines @@
 void IsolateSpawnState::DecrementSpawnCount() {
   ASSERT(spawn_count_monitor_ != NULL);
   ASSERT(spawn_count_ != NULL);
   MonitorLocker ml(spawn_count_monitor_);
   ASSERT(*spawn_count_ > 0);
   *spawn_count_ = *spawn_count_ - 1;
   ml.Notify();
 }
 
 }  // namespace dart