Issue 2554953004: Revert "Add Kernel Isolate"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2554953004: Revert "Add Kernel Isolate" (Closed)

Created:
4 years ago by hausner

Modified:
4 years ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Add Kernel Isolate" This reverts commit c9399fc5571584336eeda46e5aba4b1d5a87bd0e. The change broke Dartium and Fuchsia. BUG= Committed: https://github.com/dart-lang/sdk/commit/2ea399285a615de3e5e9d84fa67fec6736d15404

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -595 lines)			Patch
M	runtime/bin/loader.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/bin/loader.cc	View	2 chunks	+4 lines, -25 lines	0 comments	Download
M	runtime/bin/main.cc	View	6 chunks	+0 lines, -42 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	runtime/tools/kernel-service.dart	View	1 chunk	+0 lines, -146 lines	0 comments	Download
M	runtime/vm/dart.cc	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+0 lines, -39 lines	0 comments	Download
D	runtime/vm/kernel_isolate.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	runtime/vm/kernel_isolate.cc	View	1 chunk	+0 lines, -252 lines	0 comments	Download
M	runtime/vm/service_isolate.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

hausner

4 years ago (2016-12-06 22:17:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ea399285a615de3e5e9d84fa67fec6736d15404 (presubmit successful).