Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2554943002: Reland Create JSPromise (patchset #16 id:300001 of https://codereview.chromium.org/2536463002/ )" (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Create JSPromise (patchset #16 id:300001 of https://codereview.chromium.org/2536463002/ )" This reverts commit 4c7cccf9f40c063e2d6410fc35664a0efd1acb46. BUG=v8:5343 Committed: https://crrev.com/52e2c154ff18ae0e7ca807a5ad539750297c31b3 Cr-Commit-Position: refs/heads/master@{#41534}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -307 lines) Patch
M src/bootstrapper.cc View 4 chunks +22 lines, -3 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-promise.cc View 1 6 chunks +442 lines, -17 lines 0 comments Download
M src/contexts.h View 1 chunk +61 lines, -54 lines 0 comments Download
M src/debug/mirrors.js View 3 chunks +2 lines, -4 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M src/js/async-await.js View 4 chunks +2 lines, -3 lines 0 comments Download
M src/js/promise.js View 21 chunks +23 lines, -146 lines 0 comments Download
M src/objects.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M src/objects-inl.h View 4 chunks +7 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +11 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +3 lines, -28 lines 0 comments Download
M src/runtime/runtime-promise.cc View 5 chunks +86 lines, -18 lines 0 comments Download
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
gsathya
Second patchset has the fix + original patch. Diff between first and second patchset should ...
4 years ago (2016-12-06 17:49:40 UTC) #5
Benedikt Meurer
LGTM (rubber-stamped)
4 years ago (2016-12-06 18:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554943002/20001
4 years ago (2016-12-06 18:40:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 18:42:59 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 18:43:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52e2c154ff18ae0e7ca807a5ad539750297c31b3
Cr-Commit-Position: refs/heads/master@{#41534}

Powered by Google App Engine
This is Rietveld 408576698