Prevent overlay scrollbars expand or hover together

cc/input/scrollbar_animation_controller_thinning.cc

Index: cc/input/scrollbar_animation_controller_thinning.cc
diff --git a/cc/input/scrollbar_animation_controller_thinning.cc b/cc/input/scrollbar_animation_controller_thinning.cc
index 587c60f79a8b6355b1a23423c0e693ba87ac678e..d9323dfb058c8c48e09864987917f6b0ae83a999 100644
--- a/cc/input/scrollbar_animation_controller_thinning.cc
+++ b/cc/input/scrollbar_animation_controller_thinning.cc
@@ -10,11 +10,6 @@
 #include "cc/layers/scrollbar_layer_impl_base.h"
 #include "cc/trees/layer_tree_impl.h"
 
-namespace {
-const float kIdleThicknessScale = 0.4f;
-const float kDefaultMouseMoveDistanceToTriggerAnimation = 25.f;
-}
-
 namespace cc {
 
 std::unique_ptr<ScrollbarAnimationControllerThinning>
@@ -40,225 +35,144 @@ ScrollbarAnimationControllerThinning::ScrollbarAnimationControllerThinning(
     : ScrollbarAnimationController(scroll_layer_id,
                                    client,
                                    delay_before_starting,
-                                   resize_delay_before_starting),
-      opacity_(0.0f),
-      captured_(false),
-      mouse_is_over_scrollbar_(false),
-      mouse_is_near_scrollbar_(false),
-      thickness_change_(NONE),
-      mouse_move_distance_to_trigger_animation_(
-          kDefaultMouseMoveDistanceToTriggerAnimation),
-      fade_duration_(fade_duration),
-      thinning_duration_(thinning_duration),
-      current_animating_property_(OPACITY) {
-  ApplyOpacity(0.f);
-  ApplyThumbThicknessScale(kIdleThicknessScale);
+                                   resize_delay_before_starting) {
+  vertical_controller_ = SingleScrollbarAnimationControllerThinning::Create(
+      scroll_layer_id, ScrollbarOrientation::VERTICAL, client,
+      delayed_scrollbar_fade(), fade_duration, thinning_duration);
+  horizontal_controller_ = SingleScrollbarAnimationControllerThinning::Create(
+      scroll_layer_id, ScrollbarOrientation::HORIZONTAL, client,
+      delayed_scrollbar_fade(), fade_duration, thinning_duration);
 }
 
 ScrollbarAnimationControllerThinning::~ScrollbarAnimationControllerThinning() {}
 
-void ScrollbarAnimationControllerThinning::RunAnimationFrame(float progress) {
-  if (captured_)
-    return;
-
-  if (current_animating_property_ == OPACITY)
-    ApplyOpacity(1.f - progress);
+SingleScrollbarAnimationControllerThinning&
+ScrollbarAnimationControllerThinning::GetScrollbarAnimationController(
+    ScrollbarOrientation orientation) const {
+  if (orientation == ScrollbarOrientation::VERTICAL)
+    return *(vertical_controller_.get());
   else
-    ApplyThumbThicknessScale(ThumbThicknessScaleAt(progress));
-
-  client_->SetNeedsRedrawForScrollbarAnimation();
-  if (progress == 1.f) {
-    StopAnimation();
-    if (current_animating_property_ == THICKNESS) {
-      thickness_change_ = NONE;
-      SetCurrentAnimatingProperty(OPACITY);
-      if (!mouse_is_near_scrollbar_)
-        PostDelayedAnimationTask(false);
-    }
-  }
+    return *(horizontal_controller_.get());
 }
 
-const base::TimeDelta& ScrollbarAnimationControllerThinning::Duration() {
-  if (current_animating_property_ == OPACITY)
-    return fade_duration_;
-  else
-    return thinning_duration_;
+bool ScrollbarAnimationControllerThinning::mouse_is_over_scrollbar(
+    ScrollbarOrientation orientation) const {
+  return GetScrollbarAnimationController(orientation).mouse_is_over_scrollbar();
 }
 
-void ScrollbarAnimationControllerThinning::DidMouseDown() {
-  if (!mouse_is_over_scrollbar_ || opacity_ == 0.0f)
-    return;
+bool ScrollbarAnimationControllerThinning::mouse_is_near_scrollbar(
+    ScrollbarOrientation orientation) const {
+  return GetScrollbarAnimationController(orientation).mouse_is_near_scrollbar();
+}
 
-  StopAnimation();
-  captured_ = true;
-  ApplyOpacity(1.f);
-  ApplyThumbThicknessScale(1.f);
+bool ScrollbarAnimationControllerThinning::mouse_is_near_any_scrollbar() const {
+  return vertical_controller_->mouse_is_near_scrollbar() ||
+         horizontal_controller_->mouse_is_near_scrollbar();
 }
 
-void ScrollbarAnimationControllerThinning::DidMouseUp() {
-  if (!captured_ || opacity_ == 0.0f)
-    return;
+bool ScrollbarAnimationControllerThinning::captured() const {
+  return vertical_controller_->captured() || horizontal_controller_->captured();
+}
 
-  captured_ = false;
-  StopAnimation();
+bool ScrollbarAnimationControllerThinning::ScrollbarsHidden() const {
+  return hidden_;
+}
 
-  if (!mouse_is_near_scrollbar_) {
-    SetCurrentAnimatingProperty(THICKNESS);
-    thickness_change_ = DECREASE;
-    StartAnimation();
-  } else {
-    SetCurrentAnimatingProperty(OPACITY);
+void ScrollbarAnimationControllerThinning::set_mouse_move_distance_for_test(
+    float distance) {
+  vertical_controller_->set_mouse_move_distance_for_test(distance);
+  horizontal_controller_->set_mouse_move_distance_for_test(distance);
+}
+
+void ScrollbarAnimationControllerThinning::DidChangeScrollbarVisibility(
+    bool hidden) {
+  if (hidden_ != hidden) {
+    hidden_ = hidden;
+    client_->DidChangeScrollbarVisibility();
   }
 }
 
-void ScrollbarAnimationControllerThinning::DidMouseLeave() {
-  if (!mouse_is_over_scrollbar_ && !mouse_is_near_scrollbar_)
-    return;
+bool ScrollbarAnimationControllerThinning::Animate(base::TimeTicks now) {
+  bool need_animate = vertical_controller_->Animate(now);
+  need_animate = horizontal_controller_->Animate(now) || need_animate;
 
-  mouse_is_over_scrollbar_ = false;
-  mouse_is_near_scrollbar_ = false;
+  DidChangeScrollbarVisibility(vertical_controller_->ScrollbarsHidden());

[bokan, 2016/12/16 14:57:42]

The visibility should be a property of this parent controller.

More generally, I think you should separate the responsibilities:

The parent controller should be responsible for tracking and animating
visibility/opacity. The child controllers should only worry about
thinning/thickening.

 
-  if (captured_ || opacity_ == 0.0f)
-    return;
+  if (need_animate) {
+    client_->SetNeedsAnimateForScrollbarAnimation();
+  } else {
+    if (vertical_controller_->ShouldFadeOut() &&
+        horizontal_controller_->ShouldFadeOut())
+      PostDelayedAnimationTask(false);
+  }
 
-  thickness_change_ = DECREASE;
-  SetCurrentAnimatingProperty(THICKNESS);
-  StartAnimation();
+  return need_animate;
 }
 
-void ScrollbarAnimationControllerThinning::DidScrollUpdate(bool on_resize) {
-  if (captured_)
-    return;
-
-  ScrollbarAnimationController::DidScrollUpdate(on_resize);
-  ApplyOpacity(1.f);
-  ApplyThumbThicknessScale(mouse_is_near_scrollbar_ ? 1.f
-                                                    : kIdleThicknessScale);
-  SetCurrentAnimatingProperty(OPACITY);
-
-  // Don't fade out the scrollbar when mouse is near.
-  if (mouse_is_near_scrollbar_)
-    StopAnimation();
+void ScrollbarAnimationControllerThinning::RunAnimationFrame(float progress) {
+  // we delegate running the animation to the child controllers.
+  NOTREACHED();
 }
 
-void ScrollbarAnimationControllerThinning::DidScrollEnd() {
-  ScrollbarAnimationController::DidScrollEnd();
-
-  // Don't fade out the scrollbar when mouse is near.
-  if (mouse_is_near_scrollbar_)
-    StopAnimation();
+const base::TimeDelta& ScrollbarAnimationControllerThinning::Duration() {
+  // This method is deleted in ScrollbarAnimationControllerThinning
+  NOTREACHED();
+  return vertical_controller_->Duration();
 }
 
-void ScrollbarAnimationControllerThinning::DidMouseMoveNear(float distance) {
-  bool mouse_is_over_scrollbar = distance == 0.0f;
-  bool mouse_is_near_scrollbar =
-      distance < mouse_move_distance_to_trigger_animation_;
-
-  if (captured_ || opacity_ == 0.0f) {
-    mouse_is_near_scrollbar_ = mouse_is_near_scrollbar;
-    mouse_is_over_scrollbar_ = mouse_is_over_scrollbar;
-    return;
-  }
-
-  if (mouse_is_over_scrollbar == mouse_is_over_scrollbar_ &&
-      mouse_is_near_scrollbar == mouse_is_near_scrollbar_)
-    return;
-
-  if (mouse_is_over_scrollbar_ != mouse_is_over_scrollbar)
-    mouse_is_over_scrollbar_ = mouse_is_over_scrollbar;
+void ScrollbarAnimationControllerThinning::StartAnimation() {
+  ScrollbarAnimationController::StartAnimation();
 
-  if (mouse_is_near_scrollbar_ != mouse_is_near_scrollbar) {
-    mouse_is_near_scrollbar_ = mouse_is_near_scrollbar;
-    thickness_change_ = mouse_is_near_scrollbar_ ? INCREASE : DECREASE;
-  }
+  vertical_controller_->StartAnimation();
+  horizontal_controller_->StartAnimation();
+}
 
-  SetCurrentAnimatingProperty(THICKNESS);
-  StartAnimation();
+void ScrollbarAnimationControllerThinning::DidMouseDown() {
+  vertical_controller_->DidMouseDown();
+  horizontal_controller_->DidMouseDown();
 }
 
-bool ScrollbarAnimationControllerThinning::ScrollbarsHidden() const {
-  return opacity_ == 0.0f;
+void ScrollbarAnimationControllerThinning::DidMouseUp() {
+  vertical_controller_->DidMouseUp();
+  horizontal_controller_->DidMouseUp();
 }
 
-float ScrollbarAnimationControllerThinning::ThumbThicknessScaleAt(
-    float progress) {
-  if (thickness_change_ == NONE)
-    return mouse_is_near_scrollbar_ ? 1.f : kIdleThicknessScale;
-  float factor = thickness_change_ == INCREASE ? progress : (1.f - progress);
-  return ((1.f - kIdleThicknessScale) * factor) + kIdleThicknessScale;
+void ScrollbarAnimationControllerThinning::DidMouseLeave() {
+  vertical_controller_->DidMouseLeave();
+  horizontal_controller_->DidMouseLeave();
 }
 
-float ScrollbarAnimationControllerThinning::AdjustScale(
-    float new_value,
-    float current_value,
-    AnimationChange animation_change,
-    float min_value,
-    float max_value) {
-  float result;
-  if (animation_change == INCREASE && current_value > new_value)
-    result = current_value;
-  else if (animation_change == DECREASE && current_value < new_value)
-    result = current_value;
-  else
-    result = new_value;
-  if (result > max_value)
-    return max_value;
-  if (result < min_value)
-    return min_value;
-  return result;
+void ScrollbarAnimationControllerThinning::DidMouseMoveNear(
+    ScrollbarOrientation orientation,
+    float distance) {
+  GetScrollbarAnimationController(orientation).DidMouseMoveNear(distance);
 }
 
-void ScrollbarAnimationControllerThinning::ApplyOpacity(float opacity) {
-  for (ScrollbarLayerImplBase* scrollbar : Scrollbars()) {
-    if (!scrollbar->is_overlay_scrollbar())
-      continue;
-    float effective_opacity = scrollbar->CanScrollOrientation() ? opacity : 0;
-    PropertyTrees* property_trees =
-        scrollbar->layer_tree_impl()->property_trees();
-    // If this method is called during LayerImpl::PushPropertiesTo, we may not
-    // yet have valid effect_id_to_index_map entries as property trees are
-    // pushed after layers during activation. We can skip updating opacity in
-    // that case as we are only registering a scrollbar and because opacity will
-    // be overwritten anyway when property trees are pushed.
-    if (property_trees->IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT,
-                                         scrollbar->id())) {
-      property_trees->effect_tree.OnOpacityAnimated(
-          effective_opacity,
-          property_trees->effect_id_to_index_map[scrollbar->id()],
-          scrollbar->layer_tree_impl());
-    }
-  }
+void ScrollbarAnimationControllerThinning::DidScrollUpdate(bool on_resize) {
+  if (captured())
+    return;
 
-  bool previouslyVisible = opacity_ > 0.0f;
-  bool currentlyVisible = opacity > 0.0f;
+  vertical_controller_->FadeIn();
+  horizontal_controller_->FadeIn();
 
-  opacity_ = opacity;
+  DidChangeScrollbarVisibility(vertical_controller_->ScrollbarsHidden());
 
-  if (previouslyVisible != currentlyVisible)
-    client_->DidChangeScrollbarVisibility();
+  // Don't fade out the scrollbar when mouse is near.
+  if (!mouse_is_near_any_scrollbar())
+    PostDelayedAnimationTask(on_resize);
 }
 
-void ScrollbarAnimationControllerThinning::ApplyThumbThicknessScale(
-    float thumb_thickness_scale) {
-  for (ScrollbarLayerImplBase* scrollbar : Scrollbars()) {
-    if (!scrollbar->is_overlay_scrollbar())
-      continue;
-
-    scrollbar->SetThumbThicknessScaleFactor(AdjustScale(
-        thumb_thickness_scale, scrollbar->thumb_thickness_scale_factor(),
-        thickness_change_, kIdleThicknessScale, 1));
-  }
+void ScrollbarAnimationControllerThinning::DidScrollEnd() {
+  ScrollbarAnimationController::DidScrollEnd();
+  EnsureScrollbarFadeIn();
 }
 
-void ScrollbarAnimationControllerThinning::SetCurrentAnimatingProperty(
-    AnimatingProperty property) {
-  if (current_animating_property_ == property)
-    return;
-
-  StopAnimation();
-  current_animating_property_ = property;
-  if (current_animating_property_ == THICKNESS)
-    ApplyOpacity(1.f);
+void ScrollbarAnimationControllerThinning::EnsureScrollbarFadeIn() {
+  // Don't fade out the scrollbar when mouse is near.
+  if (mouse_is_near_any_scrollbar()) {
+    vertical_controller_->FadeIn();
+    horizontal_controller_->FadeIn();
+  }
 }
 
 }  // namespace cc