Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: cc/input/scrollbar_animation_controller.h

Issue 2554913002: Prevent overlay scrollbars expand or hover together (Closed)
Patch Set: fix for fade in/out together Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/scrollbar_animation_controller.h
diff --git a/cc/input/scrollbar_animation_controller.h b/cc/input/scrollbar_animation_controller.h
index bb3f810a4c2269d58267730ea97694916de2a899..fab51f592bb372e68df7b5e26df9bb7b28baa119 100644
--- a/cc/input/scrollbar_animation_controller.h
+++ b/cc/input/scrollbar_animation_controller.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "cc/base/cc_export.h"
+#include "cc/input/scrollbar.h"
#include "cc/layers/layer_impl.h"
#include "cc/layers/scrollbar_layer_impl_base.h"
#include "ui/gfx/geometry/vector2d_f.h"
@@ -37,7 +38,7 @@ class CC_EXPORT ScrollbarAnimationController {
public:
virtual ~ScrollbarAnimationController();
- bool Animate(base::TimeTicks now);
+ virtual bool Animate(base::TimeTicks now);
virtual void DidScrollBegin();
virtual void DidScrollUpdate(bool on_resize);
@@ -45,7 +46,8 @@ class CC_EXPORT ScrollbarAnimationController {
virtual void DidMouseDown() {}
virtual void DidMouseUp() {}
virtual void DidMouseLeave() {}
- virtual void DidMouseMoveNear(float distance) {}
+ virtual void DidMouseMoveNear(ScrollbarOrientation, float) {}
+ virtual void EnsureScrollbarFadeIn() {}
virtual bool ScrollbarsHidden() const;
protected:
@@ -57,14 +59,19 @@ class CC_EXPORT ScrollbarAnimationController {
virtual void RunAnimationFrame(float progress) = 0;
virtual const base::TimeDelta& Duration() = 0;
- void StartAnimation();
+ virtual void StartAnimation();
void StopAnimation();
+
ScrollbarSet Scrollbars() const;
ScrollbarAnimationControllerClient* client_;
void PostDelayedAnimationTask(bool on_resize);
+ base::CancelableClosure* delayed_scrollbar_fade() {
+ return &delayed_scrollbar_fade_;
+ }
+
int scroll_layer_id() const { return scroll_layer_id_; }
private:

Powered by Google App Engine
This is Rietveld 408576698