Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: ui/message_center/views/message_center_view.cc

Issue 2554903003: Add unittest for MessageListView (Closed)
Patch Set: fixed the build failrue on win Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_center_view.h ('k') | ui/message_center/views/message_list_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/message_center_view.cc
diff --git a/ui/message_center/views/message_center_view.cc b/ui/message_center/views/message_center_view.cc
index b95ebf55eddaa8fff5da8d18a17af35aaa2f319d..105ce6d0ad843f599ac3ac51f037ca3a8877bcf8 100644
--- a/ui/message_center/views/message_center_view.cc
+++ b/ui/message_center/views/message_center_view.cc
@@ -104,8 +104,9 @@ MessageCenterView::MessageCenterView(MessageCenter* message_center,
scroller_->layer()->SetFillsBoundsOpaquely(false);
scroller_->layer()->SetMasksToBounds(true);
- message_list_view_.reset(new MessageListView(this, top_down));
+ message_list_view_.reset(new MessageListView(top_down));
message_list_view_->set_owned_by_client();
+ message_list_view_->AddObserver(this);
// We want to swap the contents of the scroll view between the empty list
// view and the message list view, without constructing them afresh each
@@ -129,6 +130,8 @@ MessageCenterView::MessageCenterView(MessageCenter* message_center,
}
MessageCenterView::~MessageCenterView() {
+ message_list_view_->RemoveObserver(this);
+
if (!is_closing_)
message_center_->RemoveObserver(this);
}
« no previous file with comments | « ui/message_center/views/message_center_view.h ('k') | ui/message_center/views/message_list_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698