Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2554903003: Add unittest for MessageListView (Closed)

Created:
4 years ago by yoshiki
Modified:
4 years ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unittest for MessageListView BUG=671495 Committed: https://crrev.com/2de411ac87a8b34a8e53d9e4c87982e487d6a9f7 Cr-Commit-Position: refs/heads/master@{#437199}

Patch Set 1 #

Patch Set 2 : fixed the build failrue on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -22 lines) Patch
M ui/message_center/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 4 chunks +10 lines, -5 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/message_center/views/message_list_view.h View 1 5 chunks +18 lines, -10 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 3 chunks +14 lines, -6 lines 0 comments Download
A ui/message_center/views/message_list_view_unittest.cc View 1 chunk +185 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (20 generated)
yoshiki
Justin, PTAL.
4 years ago (2016-12-06 16:25:24 UTC) #5
dewittj
lgtm, thanks!
4 years ago (2016-12-07 17:11:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554903003/40001
4 years ago (2016-12-08 06:13:24 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-08 06:51:15 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-08 06:53:26 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de411ac87a8b34a8e53d9e4c87982e487d6a9f7
Cr-Commit-Position: refs/heads/master@{#437199}

Powered by Google App Engine
This is Rietveld 408576698