Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2554903002: Revert of Rotate frames correctly for back camera (Closed)

Created:
4 years ago by hbos_chromium
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rotate frames correctly for back camera (patchset #17 id:320001 of https://codereview.chromium.org/2508803002/ ) Reason for revert: Causes compile failures: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81371/steps/compile/logs/stdio Original issue's description: > Rotate frames correctly for back camera > > In 90 and 270 degree tablet mode, back camera used to show upside-down > frames. We need to rotate the frames correctly for back cameras. > > BUG=56762 > TEST=Verify that back camera shows correct preview in all rotations. > > Committed: https://crrev.com/fd4e73efe59269463f10743694597074ef2ceefb > Cr-Commit-Position: refs/heads/master@{#436594} TBR=wuchengli@chromium.org,posciak@chromium.org,henryhsu@chromium.org,mcasas@chromium.org,kcwu@chromium.org,shenghao@google.com,phistuck@gmail.com,shenghao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=56762 Committed: https://crrev.com/78ba7d636db7e127c8587977482639c387644e6f Cr-Commit-Position: refs/heads/master@{#436598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -372 lines) Patch
M media/capture/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos.h View 1 chunk +0 lines, -81 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 2 chunks +0 lines, -5 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 3 chunks +1 line, -52 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hbos_chromium
Created Revert of Rotate frames correctly for back camera
4 years ago (2016-12-06 15:10:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554903002/1
4 years ago (2016-12-06 15:11:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 15:12:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78ba7d636db7e127c8587977482639c387644e6f Cr-Commit-Position: refs/heads/master@{#436598}
4 years ago (2016-12-06 15:14:19 UTC) #8
shenghao
4 years ago (2016-12-07 06:11:08 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2558483003/ by shenghao@chromium.org.

The reason for reverting is: try to reland
https://codereview.chromium.org/2508803002/#.

Powered by Google App Engine
This is Rietveld 408576698